Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot install feature from Maven reactor module #1529

Open
bmarwell opened this issue May 24, 2022 · 1 comment
Open

Cannot install feature from Maven reactor module #1529

bmarwell opened this issue May 24, 2022 · 1 comment

Comments

@bmarwell
Copy link
Contributor

Hi,

I am using a multi-module maven project:

  • Bundle
  • Feature
  • ITs

In ITs, I defined the <type>esa</type> feature module as dependency.
However, the liberty-maven-plugin tries to download it from central only:

[INFO] Installing features: [dataSourceValidatorFeature]
Downloading from central: https://repo1.maven.org/io/openliberty/features/repository-resolver/maven-metadata.xml
[ERROR] Failed to execute goal io.openliberty.tools:liberty-maven-plugin:3.5.2:install-feature (test-init) on project datasourcevalidator.IT.liberty-recent-java8: CWWKF1203E: Unable to obtain the following features: dataSourceValidatorFeature. Ensure that the features are valid. -> [Help 1]

I wonder how plugins are supposed to be integration-tested when this plugin does not support reactor modules as dependencies.

Suggested solution

The solution is probably to add it somewhere here:
https://github.com/OpenLiberty/ci.maven/blob/main/liberty-maven-plugin/src/main/java/io/openliberty/tools/maven/InstallFeatureSupport.java#L233-L242

Known Workaround

Specify a relative path to the other module's target (not a good practice!) or use the dependency plugin to copy it to the IT module's target folder and use that as a relative path (somewhat better).

@bmarwell bmarwell closed this as not planned Won't fix, can't repro, duplicate, stale May 24, 2022
@bmarwell
Copy link
Contributor Author

Reopen, b/c of
#1530

@bmarwell bmarwell reopened this May 30, 2022
@bmarwell bmarwell changed the title Cannot install feature from reactor Cannot install feature from Maven reactor module May 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant