Peer Review - Windows [IN PROGRESS]

[MaiHameed]

Peer Review conducted on 3 platforms: Mac, Windows & Linux

• Mac OS is our base OS as the dev content team generally develops on the Mac OS.
• Conduct three separate peer reviews for each OS.

Peer Review: review to be done by a peer member.

Functionality

• Check that the guide has working instructions and sample code
• If any URL visits, try them on different browsers: Firefox, Chrome, Safari
• If any URL visits, try curl command where applicable

Formatting & Presentation

README.adoc checks:

• Ensure that command substitutions use the $(cmd) format and not `cmd`
• Ensure that the console output of the integrated tests do not include the [INFO] tab
• Check the quality and presentation of guide according to Structure and Style Guideline
• Check that the pom.xml, server.xml, etc files are clean
  • Remove any dependencies and features that are not required
  • Ensure that the parent pom.xml files do not contain any dependencies, and all dependencies are specified in the children pom.xml files
• Examples with the right outcomes are provided
• Example with the wrong outcomes, if any, are provided

pom.xml checks (if files are present):

• Check that the file follows the template found here: https://github.com/OpenLiberty/draft-guides-template/blob/master/finish/pom.xml
• Check that the following dependencies are included in all of the pom.xml files:

<!-- Provided dependencies -->
<dependency>
  <groupId>jakarta.platform</groupId>
  <artifactId>jakarta.jakartaee-api</artifactId>
  <version>8.0.0</version>
  <scope>provided</scope>
</dependency>

<dependency>
  <groupId>org.eclipse.microprofile</groupId
  <artifactId>microprofile</artifactId>
  <version>3.3</version>
  <type>pom</type>
  <scope>provided</scope>
</dependency>

• Check that the versions of plugins are directly provided and not fed in by a file property.
  • Not formatted like so:

    <properties>
        <!-- Plugins -->
        <version.liberty-maven-plugin>3.2</version.liberty-maven-plugin>
    </properties>

    <!-- Liberty plugin -->
    <plugin>
        <groupId>io.openliberty.tools</groupId>
        <artifactId>liberty-maven-plugin</artifactId>
        <version>${version.liberty-maven-plugin}</version>
    </plugin>

• Should be formatted like so:

    <!-- Liberty plugin -->
    <plugin>
        <groupId>io.openliberty.tools</groupId>
        <artifactId>liberty-maven-plugin</artifactId>
        <version>3.2</version>
    </plugin>

• Check that there are 4 spaces per indent for proper formatting
• Ensure that the guide is using the latest version of the liberty-maven-plugin or liberty-gradle-plugin where applicable

Overall checks:

• Check the consistency of guide with the template and other guides
• Check the quality of code according to the best coding practices
• Check that all licensing statements are properly stated in all files, with the correct year (Should be present in all Java files + the index.html)
• Check that the directories are properly structured
• Check that some of these page-tags are used in a guide: MicroProfile, Maven, Docker, Kubernetes, Gradle, Java EE, Security, Cloud. Only these tags are visible on the website. Latest list here.
• Check the attribution statement is accurate for the guide
• Verify the travisTest.sh script, if any, is accurate and consistent with other guides

---

• Additional tests where applicable:
  • Define test coverage and review with team (including guide contributor, if available)
  • Define detail test cases
  • Consider corner cases targeting the specific guide
  • Consider corner cases UI tests
  • Consider testing URL on all browsers, ie, FF, Chrome, Safari
  • Consider testing the curl command for URL visits
• Consider building with both Maven and Gradle build tools
• Testing with different IDEs, ie, Atom, Eclipse (Optional: VS.code, IntelliJ, Microclimate)
• Run Acrolinx Checker on draft (above 70 score approximately)
• Consider SEO title and description for the guides
• Ensure automated test is enable, set up with Travis CI, and able to schedule tests
• Run diff -r start/ finish/ and there's no differences
• Ensure that the automation tests are able to run when PR is created
• Check the appearance of the guide on test site for the following items:
  • Table of contents
  • Headings
  • Paragraphs
  • code snippets
  • outputs
  • links
  • hotspots
• Test the guide end-to-end with working instruction and sample code
• Perform all the defined test cases

[MaiHameed]

• Ensure that .travis.yml changes made in this branch and PR Replace Zipkin with Jaeger #94 don't overwrite the Travis changes I've made to fix the automation in this PR Merge qa to master: fix travis automation #98

Additional Prerequisites

• The following command does not work on Windows using the command prompt:

docker run -d --name jaeger \
  -e COLLECTOR_ZIPKIN_HTTP_PORT=9411 \
  -p 5775:5775/udp \
  -p 6831:6831/udp \
  -p 6832:6832/udp \
  -p 5778:5778 \
  -p 16686:16686 \
  -p 14268:14268 \
  -p 14250:14250 \
  -p 9411:9411 \
  jaegertracing/all-in-one:1.17

You'll need to substitute ^ instead of \:

docker run -d --name jaeger ^
  -e COLLECTOR_ZIPKIN_HTTP_PORT=9411 ^
  -p 5775:5775/udp ^
  -p 6831:6831/udp ^
  -p 6832:6832/udp ^
  -p 5778:5778 ^
  -p 16686:16686 ^
  -p 14268:14268 ^
  -p 14250:14250 ^
  -p 9411:9411 ^
  jaegertracing/all-in-one:1.17

[MaiHameed]

Continued and addressed with #107