Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update appropriate guide to show MP Metrics for Fault Tolerance 1.1 #190

Closed
gcharters opened this issue Oct 11, 2018 · 12 comments
Closed

Update appropriate guide to show MP Metrics for Fault Tolerance 1.1 #190

gcharters opened this issue Oct 11, 2018 · 12 comments
Assignees
@evelinec
Labels
dev content reviewed the content of the guide has been reviewed by committer enhancement final content reviewed final content review before publishing peer reviewed the guide has been peer reviewed question signed off the guide can proceed to publishing SME reviewed the guide has been reviewed by SME static
Projects
Open Liberty Guides Backlog Development Pipeline

Comments

@gcharters
Copy link
Member

Consider updating one of our existing guides to cover this new capability. This probably belongs in the Metrics guide because we usually talk about Fault Tolerance before we talk about Metrics.

https://openliberty.io/blog/2018/10/05/microprofile-faulttolerance-1.1-metrics.html
@gcharters gcharters added this to Unprioritized in Open Liberty Guides Backlog Oct 11, 2018
@yeekangc yeekangc moved this from Unprioritized to Prioritized in Open Liberty Guides Backlog Jan 31, 2019
@yeekangc yeekangc moved this from Prioritized to Needs Thinking in Open Liberty Guides Backlog Jan 31, 2019
@yeekangc
Copy link
Member

Need to figure out how best to cover this and whether it would warrant updates to existing guide. Does it detract from learning goals of the guide?

@Emily-Jiang, feel free to chime in.

@Emily-Jiang
Copy link
Member

Emily-Jiang commented Jan 31, 2019 •
edited

I think when you update the Fault Tolerance guide to use 1.1 version. You can add a link to a blog (https://openliberty.io/blog/2018/10/05/microprofile-faulttolerance-1.1-metrics.html) written by @Azquelt on FT metrics and also add a paragraph on the metrics aspect as there is no use code needed, just info only.

@yeekangc yeekangc mentioned this issue Apr 15, 2019
Closed
@evelinec
Copy link
Contributor

Just found that mpMetrics-2.0 doesn't provide any metrics for fault tolerance methods. mpMetrics-1.1 version does. Anyone know what may be going on?

@evelinec
Copy link
Contributor

The metrics-2.0 issue is related to OpenLiberty/open-liberty#8886.

@evelinec evelinec mentioned this issue Sep 30, 2019
Merged
@evelinec
Copy link
Contributor

evelinec commented Oct 3, 2019

Tested metrics-2.0 with cl191020191002-0300 build, it's working as expected.

@gkwan-ibm gkwan-ibm added this to Prototyping in Development Pipeline Oct 3, 2019
@gkwan-ibm gkwan-ibm moved this from Prototyping to Drafting in Development Pipeline Oct 3, 2019
@gkwan-ibm gkwan-ibm moved this from Drafting to Dev Content Reviewing in Development Pipeline Oct 3, 2019
@gkwan-ibm gkwan-ibm added the dev content reviewed the content of the guide has been reviewed by committer label Oct 3, 2019
@gkwan-ibm gkwan-ibm moved this from Dev Content Reviewing to Peer Reviewing in Development Pipeline Oct 4, 2019
@gkwan-ibm
Copy link
Member

  • Mai will do the peer view

@gkwan-ibm
Copy link
Member

gkwan-ibm commented Oct 7, 2019 •
edited

  • peer review in progress

@evelinec
Copy link
Contributor

evelinec commented Oct 7, 2019

PR is in OpenLiberty/guide-microprofile-fallback#97. @Azquelt Can you help SME review the changes? Thank you.

@gkwan-ibm gkwan-ibm added the peer reviewed the guide has been peer reviewed label Oct 8, 2019
@gkwan-ibm
Copy link
Member

  • SME review in progress

@gkwan-ibm gkwan-ibm moved this from Peer Reviewing to SME Reviewing in Development Pipeline Oct 8, 2019
@yeekangc yeekangc moved this from Needs Thinking to In Progress in Open Liberty Guides Backlog Oct 9, 2019
@gkwan-ibm gkwan-ibm added the SME reviewed the guide has been reviewed by SME label Oct 9, 2019
@gkwan-ibm
Copy link
Member

  • final review in progress

@gkwan-ibm gkwan-ibm moved this from SME Reviewing to Final Content Reviewing in Development Pipeline Oct 24, 2019
@yeekangc yeekangc moved this from In Progress to Under Review in Open Liberty Guides Backlog Nov 1, 2019
@yeekangc yeekangc added final content reviewed final content review before publishing signed off the guide can proceed to publishing labels Nov 1, 2019
@yeekangc
Copy link
Member

yeekangc commented Nov 1, 2019

Providing early signoff assuming no further/major issues.

@gkwan-ibm gkwan-ibm moved this from Final Content Reviewing to Ready to signoff in Development Pipeline Nov 4, 2019
@gkwan-ibm gkwan-ibm moved this from Ready to signoff to ID Review in Development Pipeline Nov 4, 2019
@gkwan-ibm gkwan-ibm moved this from ID Review to Post-publishing Test in Development Pipeline Nov 11, 2019
@gkwan-ibm
Copy link
Member

update was published on last night

Open Liberty Guides Backlog automation moved this from Under Review to Done Nov 13, 2019
Development Pipeline automation moved this from Post-publishing Test to Completed Nov 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@evelinec evelinec

Labels
dev content reviewed the content of the guide has been reviewed by committer enhancement final content reviewed final content review before publishing peer reviewed the guide has been peer reviewed question signed off the guide can proceed to publishing SME reviewed the guide has been reviewed by SME static
Projects
Development Pipeline
  
Completed
Open Liberty Guides Backlog
  
Done
Milestone
No milestone
Development

No branches or pull requests
5 participants
@gcharters @yeekangc @Emily-Jiang @gkwan-ibm @evelinec