Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test Failure: com.ibm.ws.testing.opentracing.test.FATOpentracing.testImmediate #10293

Closed
fmhwong opened this issue Jan 6, 2020 · 1 comment
Closed
Assignees
Labels
release bug This bug is present in a released version of Open Liberty release:20002 team:Lumberjack

Comments

@fmhwong
Copy link
Member

fmhwong commented Jan 6, 2020

RTC 270522

testImmediate:junit.framework.AssertionFailedError: EQ [ Operation ] expected:<[GET:com.ibm.ws.testing.opentracing.service.FATOpentracingService.]getTracerState> but was:<[http://localhost:8010/serviceApp/rest/testService/]getTracerState>
at com.ibm.ws.testing.opentracing.test.FATOpentracing.assertEq(FATOpentracing.java:211)
at com.ibm.ws.testing.opentracing.test.FATOpentracing.verifyTracerStateEvent(FATOpentracing.java:615)
at com.ibm.ws.testing.opentracing.test.FATOpentracing.verifyTracerStateEvent(FATOpentracing.java:597)
at com.ibm.ws.testing.opentracing.test.FATOpentracing.verifyTracerStateEvent(FATOpentracing.java:591)
at com.ibm.ws.testing.opentracing.test.FATOpentracing.testImmediate(FATOpentracing.java:657)
at componenttest.rules.repeater.RepeatTests$CompositeRepeatTestActionStatement.evaluate(RepeatTests.java:115)

@lamkavan
Copy link
Contributor

lamkavan commented Jan 15, 2020

After careful analysis by Felix Wong, the root cause of this issue is caused by a synchronization problem found within the implementation of opentracing1.x. PR to resolve issue is here #10442

In the implementation there is
protected void activate(ComponentContext context)
and
protected void setOpentracingFilterHelper(OpentracingFilterHelper helper)

These two methods needs to be synchronized such that they do not both run at the same time. If these methods run at the same time it can result in the helper for either the Container or Client filter to be NULL when using MicroProfile OpenTracing.

@fmhwong fmhwong added the release bug This bug is present in a released version of Open Liberty label Jan 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release bug This bug is present in a released version of Open Liberty release:20002 team:Lumberjack
Projects
None yet
Development

No branches or pull requests

3 participants