Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for SameSite attribute in Set-Cookie header is needed #10384

Closed
mrsaldana opened this issue Jan 10, 2020 · 1 comment · Fixed by #10383
Closed

Support for SameSite attribute in Set-Cookie header is needed #10384

mrsaldana opened this issue Jan 10, 2020 · 1 comment · Fixed by #10383
Assignees
Labels
bug This bug is not present in a released version of Open Liberty in:Transport release bug This bug is present in a released version of Open Liberty release:20002 team:Sirius

Comments

@mrsaldana
Copy link
Member

With the upcoming stable version of Chrome 80, Chrome will treat cookies as SameSite=Lax by default if no SameSite attribute is specified.
More information can be found here:
https://www.chromestatus.com/feature/5088147346030592

Setting the cookie's SameSite option in application code by adding the "set-cookie" header can result in two separate cookies, instead of the SameSite attribute reconized as an attribute to the current cookie.

For instance, an expected HTTP header in the response using SameSite should read as:

Set-Cookie: sid=noS6xWtH3tdF6eLjQVngvqk; HttpOnly; Secure; SameSite=None

However, it could be split as:

Set-Cookie: sid=noS6xWtH3tdF6eLjQVngvqk; Secure; HttpOnly
Set-Cookie: SameSite=None

@mrsaldana mrsaldana added the bug This bug is not present in a released version of Open Liberty label Jan 10, 2020
@mrsaldana mrsaldana self-assigned this Jan 10, 2020
@mrsaldana
Copy link
Member Author

fixed by #10383

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This bug is not present in a released version of Open Liberty in:Transport release bug This bug is present in a released version of Open Liberty release:20002 team:Sirius
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants