Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kafka connector can report failure for acknowledgements which eventually succeed #13404

Closed
Azquelt opened this issue Aug 10, 2020 · 0 comments · Fixed by #13405
Closed

Kafka connector can report failure for acknowledgements which eventually succeed #13404

Azquelt opened this issue Aug 10, 2020 · 0 comments · Fixed by #13405
Assignees
Labels
bug This bug is not present in a released version of Open Liberty release bug This bug is present in a released version of Open Liberty release:200010

Comments

@Azquelt
Copy link
Member

Azquelt commented Aug 10, 2020

Describe the bug

When Message.ack() is called, the kafka connector returns a result as a CompletionStage which completes when the kafka commit operation has completed successfully.

In some cases, the kafka commit operation can fail and report a retriable exception. Currently, the Kafka connector fails the CompletionStage with this retriable exception, but then goes on to run a commit operation for a later offset, causing the earlier messages to be succesfully commit.

Steps to Reproduce
Cause the kafka connector to report a retriable exception

Expected behavior
The ack() result should not complete until the commit operation has been retried and either fails with a fatal exception or succeeds.

Diagnostic information:

  • OpenLiberty Version: current master

Additional context
Found through automated testing

@Azquelt Azquelt added bug This bug is not present in a released version of Open Liberty release bug This bug is present in a released version of Open Liberty labels Aug 10, 2020
@Azquelt Azquelt self-assigned this Aug 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This bug is not present in a released version of Open Liberty release bug This bug is present in a released version of Open Liberty release:200010
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants