Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update beanValidation descriptions to mention providers used #1349

Merged
merged 1 commit into from
Dec 18, 2017
Merged

Update beanValidation descriptions to mention providers used #1349

merged 1 commit into from
Dec 18, 2017

Conversation

aguibert
Copy link
Contributor

@aguibert aguibert commented Dec 17, 2017 •
edited
Loading

No description provided.

@aguibert aguibert self-assigned this Dec 17, 2017
@LibbyBot
Copy link

Code analysis and actions

DO NOT DELETE THIS COMMENT.

  • 1 product code files were changed.

  • Please describe in a separate comment how you tested your changes.

  • 1 NLS files were changed and need an ID review.

  • @OpenLiberty/message-reviewer Please review.

  • dev/com.ibm.websphere.appserver.beanValidation-2.0/resources/l10n/com.ibm.websphere.appserver.beanValidation-2.0.properties

@aguibert
Copy link
Contributor Author

#build

@LibbyBot
Copy link

Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_aMyA8ONuEeeZaau8d5DfKQ

Target locations of links might be accessible only to IBM employees.

@aguibert aguibert changed the title Update beanValidation-2.0 description to mention use of Hibernate Val… Update beanValidation-2.0 description to mention providers used. Dec 17, 2017
@aguibert aguibert changed the title Update beanValidation-2.0 description to mention providers used. Update beanValidation descriptions to mention providers used Dec 17, 2017
@LibbyBot
Copy link

The build aguibert-1349-20171217-2217
https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_aMyA8ONuEeeZaau8d5DfKQ
completed and has errors or failures.

@sishida sishida self-assigned this Dec 18, 2017
@aguibert aguibert requested a review from njr-11 December 18, 2017 14:16
sishida
sishida reviewed Dec 18, 2017
View reviewed changes
....beanValidation-2.0/resources/l10n/com.ibm.websphere.appserver.beanValidation-2.0.properties
@@ -16,4 +16,4 @@

description=The Bean Validation 2.0 specification provides an annotation based model for validating \
JavaBeans. It can be used to assert and maintain the integrity of data as it travels through \
an application.
an application. This feature is built on top of the Hibernate Validator Engine.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure we need to capitalize "Engine." We only need to capitalize it here if the word "Engine" is part of the product name, such as how in "WebSphere Application Server," the word "Server" is part of the name. :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

correct, in this case Engine is part of the name

@aguibert aguibert merged commit 8a2f5e1 into OpenLiberty:integration Dec 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sishida sishida sishida left review comments

@njr-11 njr-11 njr-11 approved these changes

Assignees

@aguibert aguibert

@sishida sishida

Labels
CLA Signed ID reviewed in:Bean Validation release-18.0.0.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@aguibert @LibbyBot @njr-11 @sishida