JSTL Refactoring & Pull in JSTL 2.0 Impl #15141

volosied · 2020-12-01T14:42:36Z

Overview of the changes

Pulled out JSTL Impl (1.2) out of com.ibm.ws.jsp and placed it into the new com.ibm.ws.org.apache.taglibs.standard

  @${repo;com.ibm.ws.javax.j2ee:jsp.tld.standard;1.2}, \
   @${repo;com.ibm.ws.org.apache:xalan;2.7.2}!/!META-INF/*, \

Pulled in the latest EE4J JSTL implementation ( org.glassfish.web:jakarta.servlet.jsp.jstl:2.0.0 ) and created io.openliberty.org.apache.taglibs.standard
- The two taglib components above are now fragments. Their bnd files have the following added: Fragment-Host: com.ibm.ws.jsp(.jakarta)
Updated JSTL facade bundle to import versions 1.2 and the transformer changes them to 2.0 for the Pages 3.0 feature.
- This change was done so that the versions would all align with the new JSTL bundles
Created io.openliberty.jstl.facade (which is basically the jakarta version of com.ibm.ws.jsp.jstl.facade)

volosied · 2020-12-01T14:43:44Z

#build

LibbyBot · 2020-12-01T14:43:47Z

Please code review feature-related files, @OpenLiberty/delivery-approvers

LibbyBot · 2020-12-01T14:43:51Z

Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_Psk0QDPbEeufrbKPAMj-zQ

Target locations of links might be accessible only to IBM employees.

dev/com.ibm.ws.jsp/bnd.bnd

LibbyBot · 2020-12-01T18:14:07Z

Your Open Liberty build results are ready for viewing.

Unit test results are at http://public.dhe.ibm.com/ibmdl/export/pub/software/openliberty/runtime/personal/_Psk0QDPbEeufrbKPAMj-zQ/junit/index.html.
Gradle log and image zip are at http://public.dhe.ibm.com/ibmdl/export/pub/software/openliberty/runtime/personal/_Psk0QDPbEeufrbKPAMj-zQ.

LibbyBot · 2020-12-02T04:03:57Z

The build volosied-15141-20201201-1451
https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_Psk0QDPbEeufrbKPAMj-zQ
completed and has errors or failures.

For help analyzing your personal build, go to https://cognitive.hursley.ibm.com/buildAnalysis.html?uuid=_Psk0QDPbEeufrbKPAMj-zQ

volosied · 2020-12-02T18:31:38Z

#build

LibbyBot · 2020-12-02T18:31:42Z

Please code review feature-related files, @OpenLiberty/delivery-approvers

LibbyBot · 2020-12-02T18:31:47Z

Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_QIy2UDTEEeufrbKPAMj-zQ

Target locations of links might be accessible only to IBM employees.

LibbyBot · 2020-12-02T21:06:31Z

Your Open Liberty build results are ready for viewing.

Unit test results are at http://public.dhe.ibm.com/ibmdl/export/pub/software/openliberty/runtime/personal/_QIy2UDTEEeufrbKPAMj-zQ/junit/index.html.
Gradle log and image zip are at http://public.dhe.ibm.com/ibmdl/export/pub/software/openliberty/runtime/personal/_QIy2UDTEEeufrbKPAMj-zQ.

volosied · 2020-12-03T15:30:22Z

#build

LibbyBot · 2020-12-03T15:30:27Z

Please code review feature-related files, @OpenLiberty/delivery-approvers

LibbyBot · 2020-12-03T15:30:29Z

Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_FyjLQDV0EeufrbKPAMj-zQ

Target locations of links might be accessible only to IBM employees.

volosied · 2020-12-03T18:05:31Z

#build

LibbyBot · 2020-12-03T18:05:37Z

Please code review feature-related files, @OpenLiberty/delivery-approvers

LibbyBot · 2020-12-03T18:05:40Z

Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_xQv5IDWJEeufrbKPAMj-zQ

Target locations of links might be accessible only to IBM employees.

LibbyBot · 2020-12-03T18:59:07Z

Your Open Liberty build results are ready for viewing.

Unit test results are at http://public.dhe.ibm.com/ibmdl/export/pub/software/openliberty/runtime/personal/_FyjLQDV0EeufrbKPAMj-zQ/junit/index.html.
Gradle log and image zip are at http://public.dhe.ibm.com/ibmdl/export/pub/software/openliberty/runtime/personal/_FyjLQDV0EeufrbKPAMj-zQ.

volosied · 2021-01-11T20:47:08Z

#build

volosied · 2021-01-12T15:20:04Z

Build requested here: https://wasrtc.hursley.ibm.com:9443/jazz/web/projects/WS-CD#action=com.ibm.team.build.viewResult&id=_J4qTYFThEeuFI6_BZVYvOw

Locally the JSP 2.3 FAT & Webcontainer Servlet 4.0 FAT pass everything.

LibbyBot · 2021-01-12T19:22:05Z

Your Open Liberty build results are ready for viewing.

Unit test results are at http://public.dhe.ibm.com/ibmdl/export/pub/software/openliberty/runtime/personal/_J4qTYFThEeuFI6_BZVYvOw/junit/index.html.
Gradle log and image zip are at http://public.dhe.ibm.com/ibmdl/export/pub/software/openliberty/runtime/personal/_J4qTYFThEeuFI6_BZVYvOw.

LibbyBot · 2021-01-13T05:04:54Z

The build volosied-15141-20210112-0727
https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_J4qTYFThEeuFI6_BZVYvOw
completed and has errors or failures.

For help analyzing your personal build, go to https://cognitive.hursley.ibm.com/buildAnalysis.html?uuid=_J4qTYFThEeuFI6_BZVYvOw

volosied · 2021-01-13T18:17:46Z

#build #spawn.fullfat.buckets=com.ibm.ws.jsp.2.3_fat,com.ibm.ws.jsp_fat,com.ibm.ws.webcontainer.servlet.4.0_fat

LibbyBot · 2021-01-13T18:17:54Z

Please code review feature-related files, @OpenLiberty/delivery-approvers

LibbyBot · 2021-01-13T18:17:56Z

Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_RqdgEFXDEeuFI6_BZVYvOw

Target locations of links might be accessible only to IBM employees.

LibbyBot · 2021-01-13T22:52:23Z

Your Open Liberty build results are ready for viewing.

Unit test results are at http://public.dhe.ibm.com/ibmdl/export/pub/software/openliberty/runtime/personal/_RqdgEFXDEeuFI6_BZVYvOw/junit/index.html.
Gradle log and image zip are at http://public.dhe.ibm.com/ibmdl/export/pub/software/openliberty/runtime/personal/_RqdgEFXDEeuFI6_BZVYvOw.

volosied · 2021-01-14T16:45:55Z

#build #spawn.fullfat.buckets=com.ibm.ws.jsp.2.3_fat,com.ibm.ws.jsp_fat,com.ibm.ws.webcontainer.servlet.4.0_fat

LibbyBot · 2021-01-14T16:46:05Z

Please code review feature-related files, @OpenLiberty/delivery-approvers

LibbyBot · 2021-01-14T16:46:09Z

Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_nrnjsFZ_EeuFI6_BZVYvOw

Target locations of links might be accessible only to IBM employees.

LibbyBot · 2021-01-14T21:07:12Z

Your Open Liberty build results are ready for viewing.

Unit test results are at http://public.dhe.ibm.com/ibmdl/export/pub/software/openliberty/runtime/personal/_nrnjsFZ_EeuFI6_BZVYvOw/junit/index.html.
Gradle log and image zip are at http://public.dhe.ibm.com/ibmdl/export/pub/software/openliberty/runtime/personal/_nrnjsFZ_EeuFI6_BZVYvOw.

LibbyBot · 2021-01-15T04:55:22Z

Your Open Liberty build results are ready for viewing.

Unit test results are at http://public.dhe.ibm.com/ibmdl/export/pub/software/openliberty/runtime/personal/_8rfGsFa9EeuFI6_BZVYvOw/junit/index.html.
Gradle log and image zip are at http://public.dhe.ibm.com/ibmdl/export/pub/software/openliberty/runtime/personal/_8rfGsFa9EeuFI6_BZVYvOw.

volosied · 2021-01-17T02:23:29Z

#build #spawn.fullfat.buckets=com.ibm.ws.jsp.2.3_fat,com.ibm.ws.jsp_fat,com.ibm.ws.webcontainer.servlet.4.0_fat

LibbyBot · 2021-01-17T02:23:34Z

Please code review feature-related files, @OpenLiberty/delivery-approvers

LibbyBot · 2021-01-17T02:23:41Z

Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_oaEVoFhiEeuM3vrL9EeJlQ

Target locations of links might be accessible only to IBM employees.

LibbyBot · 2021-01-18T14:03:03Z

The build volosied-15141-20210116-1830
https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_oaEVoFhiEeuM3vrL9EeJlQ
completed successfully!

LibbyBot · 2021-01-18T14:46:57Z

Your Open Liberty build results are ready for viewing.

Unit test results are at http://public.dhe.ibm.com/ibmdl/export/pub/software/openliberty/runtime/personal/_oaEVoFhiEeuM3vrL9EeJlQ/junit/index.html.
Gradle log and image zip are at http://public.dhe.ibm.com/ibmdl/export/pub/software/openliberty/runtime/personal/_oaEVoFhiEeuM3vrL9EeJlQ.

pnicolucci

Looks good. Thanks!

volosied · 2021-01-19T19:33:59Z

#run-libby-bot

LibbyBot · 2021-01-19T19:34:07Z

Code analysis and actions

DO NOT DELETE THIS COMMENT.

10 product code files were changed.
Please describe in a separate comment how you tested your changes.
13 infrastructure code files were changed.

volosied self-assigned this Dec 1, 2020

LibbyBot added the CLA Signed label Dec 1, 2020

volosied marked this pull request as draft December 1, 2020 14:43

tevans78 reviewed Dec 1, 2020

View reviewed changes

dev/com.ibm.ws.jsp/bnd.bnd Outdated Show resolved Hide resolved

volosied force-pushed the 11643-JSTL-refactoring branch from 5dab6f2 to 5b5b6df Compare December 2, 2020 20:56

volosied force-pushed the 11643-JSTL-refactoring branch 5 times, most recently from 136ec5b to 095f9f3 Compare December 3, 2020 17:52

volosied marked this pull request as ready for review December 3, 2020 18:05

volosied requested review from isaacrivriv and pnicolucci December 3, 2020 18:06

volosied requested a review from tjwatson December 3, 2020 19:40

volosied force-pushed the 11643-JSTL-refactoring branch 2 times, most recently from cff3fa7 to 1e95a6b Compare January 13, 2021 18:16

volosied force-pushed the 11643-JSTL-refactoring branch from 1e95a6b to 3e88dfa Compare January 14, 2021 15:13

volosied force-pushed the 11643-JSTL-refactoring branch from 3e88dfa to 03a686f Compare January 17, 2021 02:22

Update Taglib Bnds

35f537a

volosied force-pushed the 11643-JSTL-refactoring branch from 03a686f to 35f537a Compare January 17, 2021 02:25

pnicolucci approved these changes Jan 19, 2021

View reviewed changes

volosied merged commit cafc601 into OpenLiberty:integration Jan 19, 2021

volosied mentioned this pull request Feb 12, 2021

Investigate RequirementImpl#getNamespace for EE9 (Pages/JSTL) #15290

Closed

volosied changed the title ~~JSTL Refactoring~~ JSTL Refactoring & Pull in JSTL 2.0 Impl Sep 28, 2021

JSTL Refactoring & Pull in JSTL 2.0 Impl #15141

JSTL Refactoring & Pull in JSTL 2.0 Impl #15141

Conversation

volosied commented Dec 1, 2020 • edited

volosied commented Dec 1, 2020

LibbyBot commented Dec 1, 2020

LibbyBot commented Dec 1, 2020

LibbyBot commented Dec 1, 2020

LibbyBot commented Dec 2, 2020

volosied commented Dec 2, 2020

LibbyBot commented Dec 2, 2020

LibbyBot commented Dec 2, 2020

LibbyBot commented Dec 2, 2020

volosied commented Dec 3, 2020

LibbyBot commented Dec 3, 2020

LibbyBot commented Dec 3, 2020

volosied commented Dec 3, 2020

LibbyBot commented Dec 3, 2020

LibbyBot commented Dec 3, 2020

LibbyBot commented Dec 3, 2020

volosied commented Jan 11, 2021

volosied commented Jan 12, 2021 • edited

LibbyBot commented Jan 12, 2021

LibbyBot commented Jan 13, 2021

volosied commented Jan 13, 2021

LibbyBot commented Jan 13, 2021

LibbyBot commented Jan 13, 2021

LibbyBot commented Jan 13, 2021

volosied commented Jan 14, 2021

LibbyBot commented Jan 14, 2021

LibbyBot commented Jan 14, 2021

LibbyBot commented Jan 14, 2021

LibbyBot commented Jan 15, 2021

volosied commented Jan 17, 2021

LibbyBot commented Jan 17, 2021

LibbyBot commented Jan 17, 2021

LibbyBot commented Jan 18, 2021

LibbyBot commented Jan 18, 2021

pnicolucci left a comment

Choose a reason for hiding this comment

volosied commented Jan 19, 2021

LibbyBot commented Jan 19, 2021

Code analysis and actions

volosied commented Dec 1, 2020 •

edited

volosied commented Jan 12, 2021 •

edited