Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace DNS lookup with regular expression to get the domain name in SSO Cookie Domain function #15336

Closed
una-tapa opened this issue Dec 17, 2020 · 1 comment
Closed

Replace DNS lookup with regular expression to get the domain name in SSO Cookie Domain function #15336

una-tapa opened this issue Dec 17, 2020 · 1 comment
Assignees
@una-tapa
Labels
bug This bug is not present in a released version of Open Liberty release bug This bug is present in a released version of Open Liberty release:21004

Comments

@una-tapa
Copy link
Member

una-tapa commented Dec 17, 2020 •
edited
Loading

Describe the bug
A bug in the SSO Cookie domain function that unnecessarily makes DNS lookup.

Steps to Reproduce
Just send a regular HTTP Request to generate LTPA token.

Expected behavior
Avoid expensive DNS lookup whenever possible.

Diagnostic information:

  • OpenLiberty Version: 20.0.0.9
  • Java Version: The issue is not relevant to Java version.
  • server.xml configuration: Web feature needs to be enabled.
  • If it would be useful, upload the messages.log file found in $WLP_OUTPUT_DIR/messages.log

Additional context
Add any other context about the problem here.
@una-tapa una-tapa added the bug This bug is not present in a released version of Open Liberty label Dec 17, 2020
@una-tapa una-tapa self-assigned this Dec 17, 2020
@una-tapa una-tapa mentioned this issue Dec 18, 2020
Merged
@una-tapa una-tapa added the release bug This bug is present in a released version of Open Liberty label Mar 18, 2021
@una-tapa una-tapa changed the title Bug fix in SSO Cookie Domain function Replace DNS lookup with regular expression to get the domain name in SSO Cookie Domain function Mar 24, 2021
@una-tapa
Copy link
Member Author

Closing the issue. Received positive feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@una-tapa una-tapa

Labels
bug This bug is not present in a released version of Open Liberty release bug This bug is present in a released version of Open Liberty release:21004
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@una-tapa @LibbyBot