Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve featureUtility performance with remote repository #16700

Closed
jjiwooLim opened this issue Apr 20, 2021 · 4 comments · Fixed by #16953
Closed

Improve featureUtility performance with remote repository #16700

jjiwooLim opened this issue Apr 20, 2021 · 4 comments · Fixed by #16953
Assignees
Labels
bug This bug is not present in a released version of Open Liberty in:Install release bug This bug is present in a released version of Open Liberty release:21008 release:21009

Comments

@jjiwooLim
Copy link
Contributor

jjiwooLim commented Apr 20, 2021

FeatureUtility can take a long time to resolve features when using a remote repository with a slow network.

Areas that could be improved:

  1. Check and retrieve more than one checksums from maven repository
  2. Check more than one artifact urls for missing features
@jdmcclur
Copy link
Member

  1. Look into caching assets instead of jsonobjects and caching per file so a file doesn't need to be parsed/deserialized more than once. This won't help with a slow network, but will speed things up.

@jdmcclur
Copy link
Member

  1. Download more than 1 file at once -

@jjiwooLim
Copy link
Contributor Author

  1. Changing SingleFileRepositoryConnection to cache the client between calls to createClient would significantly reduce the json parsing we do. It looks like the SingleFileClient class already detects changes to the underlying file and repress as necessary so I think this would be safe:

@jjiwooLim
Copy link
Contributor Author

  1. Looking at the feature.json file it seems that the json contains the sha256 of the downloaded esa file so there is no need to download the sha hash from maven central because we can already validate the download using the json content.

@bensonlatibm bensonlatibm added Epic Used to track Feature Epics that are following the UFO process No Design Approval Request Must NOT need: SVT/Perf testing, new UI, Servicibility considerations, major doc updates labels May 13, 2021
@malincoln malincoln added the In Progress Items that are in active development. label Jun 7, 2021
@jjiwooLim jjiwooLim removed Epic Used to track Feature Epics that are following the UFO process No Design Approval Request Must NOT need: SVT/Perf testing, new UI, Servicibility considerations, major doc updates labels Jun 24, 2021
@jjiwooLim jjiwooLim removed the In Progress Items that are in active development. label Aug 5, 2021
@jjiwooLim jjiwooLim added the bug This bug is not present in a released version of Open Liberty label Aug 5, 2021
@malincoln malincoln removed this from Foundation in Open Liberty Roadmap Aug 5, 2021
@jjiwooLim jjiwooLim added the release bug This bug is present in a released version of Open Liberty label Aug 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This bug is not present in a released version of Open Liberty in:Install release bug This bug is present in a released version of Open Liberty release:21008 release:21009
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants