Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gRPC server property "httpEndpoints" is invalid #19348

Closed
wtlucy opened this issue Nov 12, 2021 · 0 comments · Fixed by #19360
Closed

gRPC server property "httpEndpoints" is invalid #19348

wtlucy opened this issue Nov 12, 2021 · 0 comments · Fixed by #19360
Assignees
@wtlucy
Labels
in:Transport POC Approved release bug This bug is present in a released version of Open Liberty release:22001 team:Sirius
Projects
Web Tier Team

Comments

@wtlucy
Copy link
Contributor

wtlucy commented Nov 12, 2021

Describe the bug
The gRPC Server Properties (grpc) reference a configuration property named httpEndpoints. This property has no effect.

Steps to Reproduce
Configure a server.xml with <grpc httpEndpoints="<valid_http_endpoint_ids>"/> - gRPC requests will not be restricted to the specified endpoints, as described in the documentation.

Expected behavior
The httpEndpoints property is invalid - and should not have been included in the Liberty metatype and documentation. The desired behavior of restricting a gRPC service to a particular endpoint(s) can be attained via virtual hosts.

Diagnostic information:

  • OpenLiberty Version: 20.0.0.12+
  • Affected feature(s) grpc-1.0
  • Java Version: N/A
  • server.xml configuration <grpc httpEndpoints="<valid_http_endpoint_ids>"/>

Additional context
@wtlucy wtlucy added the release bug This bug is present in a released version of Open Liberty label Nov 12, 2021
@wtlucy wtlucy self-assigned this Nov 12, 2021
@wtlucy wtlucy added this to General Issues in Web Tier Team via automation Nov 12, 2021
@wtlucy wtlucy mentioned this issue Nov 15, 2021
Merged
@wtlucy wtlucy moved this from General Issues to gRPC - Open Work in Web Tier Team Nov 15, 2021
Web Tier Team automation moved this from gRPC - Open Work to Completed Tasks Dec 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wtlucy wtlucy

Labels
in:Transport POC Approved release bug This bug is present in a released version of Open Liberty release:22001 team:Sirius
Projects
Web Tier Team
Archived in project
Web Tier Team
  
Completed Tasks
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

remove unused gRPC httpEndpoint config prop wtlucy/open-liberty
3 participants
@mbroz2 @wtlucy @LibbyBot