Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ConcurrentModificationException during app startup #2175

Conversation

pmd1nh
Copy link
Member

@pmd1nh pmd1nh commented Feb 13, 2018

No description provided.

@LibbyBot
Copy link

Code analysis and actions

DO NOT DELETE THIS COMMENT.
  • 1 product code files were changed.
  • Please describe in a separate comment how you tested your changes.

@pmd1nh pmd1nh requested a review from zaroman February 13, 2018 18:58
@pmd1nh
Copy link
Member Author

pmd1nh commented Feb 13, 2018

#build

@LibbyBot
Copy link

Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_h-mMwBDnEeiStsw2He7iFw

Target locations of links might be accessible only to IBM employees.

@pmd1nh pmd1nh merged commit 8a3df94 into OpenLiberty:integration Feb 13, 2018
@LibbyBot
Copy link

The build pmd1nh-2175-20180213-2045
https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_h-mMwBDnEeiStsw2He7iFw
completed and has errors or failures.

@ewhoch
Copy link
Contributor

ewhoch commented Feb 15, 2018

This is causing a hard failure in the JDBC FAT since the change to concurrent hashmap doesn't allow null values, so this needs to come out:

java.lang.NullPointerException
	at java.util.concurrent.ConcurrentHashMap.putVal(ConcurrentHashMap.java:1022)
	at java.util.concurrent.ConcurrentHashMap.put(ConcurrentHashMap.java:1017)
	at com.ibm.ws.webcontainer.webapp.WebAppConfiguration.addServletInfo(WebAppConfiguration.java:245)
	at com.ibm.ws.webcontainer.osgi.container.config.WebAppConfiguratorHelper$ConfigurationWriter.addServletInfo(WebAppConfiguratorHelper.java:387)
	at com.ibm.ws.webcontainer.osgi.container.config.WebAppConfiguratorHelper.processServletConfig(WebAppConfiguratorHelper.java:3001)
	at com.ibm.ws.webcontainer.osgi.container.config.WebAppConfiguratorHelper.configureServlets(WebAppConfiguratorHelper.java:2347)
	at com.ibm.ws.webcontainer.osgi.container.config.WebAppConfiguratorHelper.configureFromWebApp(WebAppConfiguratorHelper.java:748)
	at com.ibm.ws.webcontainer.osgi.container.config.WebAppConfigurator.configure(WebAppConfigurator.java:402)
	at com.ibm.ws.webcontainer.osgi.container.config.WebAppConfigurationAdapter.adapt(WebAppConfigurationAdapter.java:119)
	at com.ibm.ws.webcontainer.osgi.container.config.WebAppConfigurationAdapter.adapt(WebAppConfigurationAdapter.java:43)
	at com.ibm.ws.adaptable.module.internal.AdapterFactoryServiceImpl.adapt(AdapterFactoryServiceImpl.java:193)
	at com.ibm.ws.adaptable.module.internal.AdaptableContainerImpl.adapt(AdaptableContainerImpl.java:170)
	at com.ibm.ws.webcontainer.osgi.WebContainer.createModuleMetaData(WebContainer.java:833)
	at com.ibm.ws.app.manager.module.internal.ModuleHandlerBase.createModuleMetaData(ModuleHandlerBase.java:63)
	at com.ibm.ws.app.manager.module.internal.SimpleDeployedAppInfoBase$ModuleContainerInfoBase.createModuleMetaData(SimpleDeployedAppInfoBase.java:168)
	at com.ibm.ws.app.manager.module.internal.DeployedAppInfoBase.preDeployApp(DeployedAppInfoBase.java:368)
	at com.ibm.ws.app.manager.module.internal.DeployedAppInfoBase.deployApp(DeployedAppInfoBase.java:412)
	at com.ibm.ws.app.manager.war.internal.WARApplicationHandlerImpl.install(WARApplicationHandlerImpl.java:65)
	at com.ibm.ws.app.manager.internal.statemachine.StartAction.execute(StartAction.java:140)
	at com.ibm.ws.app.manager.internal.statemachine.ApplicationStateMachineImpl.enterState(ApplicationStateMachineImpl.java:1258)
	at com.ibm.ws.app.manager.internal.statemachine.ApplicationStateMachineImpl.run(ApplicationStateMachineImpl.java:873)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1153)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
	at java.lang.Thread.run(Thread.java:785)

@ewhoch
Copy link
Contributor

ewhoch commented Feb 15, 2018

this was for #1952

@pmd1nh pmd1nh deleted the 1952-ConcurrentModificationException_during_application_startup branch February 21, 2018 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants