Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use mininum jdkSourceLevel of 1.8 for JDK 20+ #23885

Closed
epj opened this issue Jan 11, 2023 · 0 comments · Fixed by #23911
Closed

Use mininum jdkSourceLevel of 1.8 for JDK 20+ #23885

epj opened this issue Jan 11, 2023 · 0 comments · Fixed by #23911
Assignees
@epj
Labels
in:Web Components release bug This bug is present in a released version of Open Liberty release:23001 team:Sirius
Projects
Web Tier Team

Comments

@epj
Copy link
Contributor

epj commented Jan 11, 2023 •
edited
Loading

Describe the bug
In JDK20, javac has removed support for Java 1.7 compiling. JSP needs an update to the code that checks jdkSourceLevel. Until this is done errors like the following will happen when jdkSourceLevel="17" (meaning Java 1.7) is specified:

com.ibm.ws.jsp.JspCoreException: JSPG0049E: /xxxxxxxxx.jsp failed to compile :
error: Source option 7 is no longer supported. Use 8 or later.

Steps to Reproduce
See above.

Expected behavior
The jdkSourceLevel specified by the user will be overrided to "18" if a lower level is specified, when Java 20 or higher is the runtime.
@epj epj added in:Web Components release bug This bug is present in a released version of Open Liberty team:Sirius labels Jan 11, 2023
@epj epj self-assigned this Jan 11, 2023
@epj epj added this to General Issues in Web Tier Team via automation Jan 11, 2023
This was referenced Jan 13, 2023
Closed
Merged
Web Tier Team automation moved this from General Issues to Completed Tasks Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@epj epj

Labels
in:Web Components release bug This bug is present in a released version of Open Liberty release:23001 team:Sirius
Projects
Web Tier Team
Archived in project
Web Tier Team
  
Completed Tasks
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

For Java 20, JSP adjust option jdkSourceLevel up to level 8 if not already epj/open-liberty
2 participants
@LibbyBot @epj