Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WithSpan anotation does not work when name or kind is set #25429

Closed
gkwan-ibm opened this issue Jun 6, 2023 · 2 comments · Fixed by #25449
Closed

WithSpan anotation does not work when name or kind is set #25429

gkwan-ibm opened this issue Jun 6, 2023 · 2 comments · Fixed by #25449
Assignees
Labels
in:MicroProfile/Telemetry release bug This bug is present in a released version of Open Liberty release:23007

Comments

@gkwan-ibm
Copy link
Member

gkwan-ibm commented Jun 6, 2023

Describe the bug
Followed the example in the https://openliberty.io/docs/latest/microprofile-telemetry.html#manual doc. Annotated a bean's methods with @WithSpan("name"), but the Jagear server does not show traces for the annotated methods.

Expected behavior
Jagear server should show traces for the annotated methods.

Diagnostic information:

  • OpenLiberty Version: 23.0.0.5
  • Affected feature(s): mpTelemetry-1.0
  • Java Version: 11
@gkwan-ibm gkwan-ibm added the release bug This bug is present in a released version of Open Liberty label Jun 6, 2023
@Azquelt Azquelt added this to Backlog in MicroProfile UK via automation Jun 6, 2023
@Azquelt Azquelt moved this from Backlog to Planned in MicroProfile UK Jun 6, 2023
@Azquelt
Copy link
Member

Azquelt commented Jun 6, 2023

I've looked into @gkwan-ibm's scenario but I'm not sure yet why it isn't working but our FAT tests for this area pass.

@Azquelt
Copy link
Member

Azquelt commented Jun 7, 2023

@yasmin-aumeeruddy found that the problem only occurs when a name is provided in the annotation (e.g. @WithSpan("myName")).

Without the name, the span is created correctly.

From this we realised that we are missing @Nonbinding annotations on our copy of the @WithSpan annotation.

I will update the defect description to clarify when the problem occurs.

@Azquelt Azquelt changed the title WithSpan anotation does not work WithSpan anotation does not work when name or kind is set Jun 7, 2023
@Azquelt Azquelt self-assigned this Jun 9, 2023
@Azquelt Azquelt moved this from Planned to In Progress in MicroProfile UK Jun 9, 2023
MicroProfile UK automation moved this from In Progress to Done Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in:MicroProfile/Telemetry release bug This bug is present in a released version of Open Liberty release:23007
Projects
Development

Successfully merging a pull request may close this issue.

3 participants