Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REVERTED] Port MYFACES-4606 #26216

Merged
merged 8 commits into from
Sep 19, 2023
Merged

[REVERTED] Port MYFACES-4606 #26216

merged 8 commits into from
Sep 19, 2023

Conversation

volosied
Copy link
Member

@volosied volosied commented Sep 7, 2023 •
edited
Loading

fixes #26221

@volosied volosied self-assigned this Sep 7, 2023
@LibbyBot
Copy link

LibbyBot commented Sep 7, 2023

The following files contain a string indicating discriminating content:

  • dev/io.openliberty.jakarta.faces.3.0/src/META-INF/internal-resources/org.apache.myfaces.core.impl.util/_UnitTest.js
  • dev/com.ibm.websphere.javaee.jsf.2.3/src/META-INF/internal-resources/org.apache.myfaces.core.impl.util/_UnitTest.js

@posmith
Copy link

posmith commented Sep 7, 2023

L2 message review not required

@volosied
Copy link
Member Author

volosied commented Sep 7, 2023

I'll remove the overlays for the message files.

@dmuelle
Copy link
Member

dmuelle commented Sep 7, 2023

Hi @volosied -are there new messages here that need ID review? The Libbybot is flagging a bunch of files but can't tell if any of them actually changed.

If not, you can add the ID review not needed label to bypass review. Thanks

@volosied volosied force-pushed the MYFACES-4606 branch 3 times, most recently from 157e363 to 80a8ee8 Compare September 8, 2023 13:56
@volosied
Copy link
Member Author

volosied commented Sep 8, 2023

#build

@LibbyBot
Copy link

LibbyBot commented Sep 8, 2023

Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_JRUf0E5HEe6qN7oUI8eADQ

Target locations of links might be accessible only to IBM employees.

@volosied
Copy link
Member Author

volosied commented Sep 8, 2023

#build

@volosied volosied added the release bug This bug is present in a released version of Open Liberty label Sep 8, 2023
@LibbyBot
Copy link

LibbyBot commented Sep 8, 2023

Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_hqH0sE5dEe6qN7oUI8eADQ

Target locations of links might be accessible only to IBM employees.

@LibbyBot
Copy link

LibbyBot commented Sep 9, 2023

The build volosied-26216-20230908-0951
https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_hqH0sE5dEe6qN7oUI8eADQ
completed and has errors or failures.

For help analyzing your personal build, go to https://libh-proxy1.fyre.ibm.com/cognitive/buildAnalysis.html?uuid=_hqH0sE5dEe6qN7oUI8eADQ

@volosied
Copy link
Member Author

#build

@LibbyBot
Copy link

Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_lcy7QFCxEe6zvJP4IbpA3g

Target locations of links might be accessible only to IBM employees.

@LibbyBot
Copy link

The build volosied-26216-20230911-0851
https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_lcy7QFCxEe6zvJP4IbpA3g
completed and has errors or failures.

For help analyzing your personal build, go to https://libh-proxy1.fyre.ibm.com/cognitive/buildAnalysis.html?uuid=_lcy7QFCxEe6zvJP4IbpA3g

@volosied volosied force-pushed the MYFACES-4606 branch 2 times, most recently from 94f130d to a4d501e Compare September 12, 2023 15:37
@volosied
Copy link
Member Author

#build

@LibbyBot
Copy link

Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_Sl6-AFGEEe6zvJP4IbpA3g

Target locations of links might be accessible only to IBM employees.

@LibbyBot
Copy link

The build volosied-26216-20230912-1002
https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_Sl6-AFGEEe6zvJP4IbpA3g
completed successfully!

@volosied
Copy link
Member Author

#libby

@LibbyBot
Copy link

Code analysis and actions

DO NOT DELETE THIS COMMENT.

WARNING: This pull request contains binary files, which should be managed in a Maven repository.

  • 36 product code files were changed.

  • Please describe in a separate comment how you tested your changes.

  • 8 FAT files were changed, added, or removed.

  • Check that the build did not break the affected FAT suite(s).

@volosied volosied merged commit 829f55b into OpenLiberty:integration Sep 19, 2023
2 checks passed
@volosied volosied mentioned this pull request Sep 28, 2023
Merged
@LibbyBot LibbyBot mentioned this pull request Sep 28, 2023
Open
@volosied volosied mentioned this pull request Nov 21, 2023
Merged
@volosied volosied changed the title Port MYFACES-4606 [REVERTED] Port MYFACES-4606 Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pnicolucci pnicolucci pnicolucci approved these changes

Assignees

@volosied volosied

Labels
ID review not needed in:Web Components L2 ReviewNotRequired release bug This bug is present in a released version of Open Liberty release:230010 team:Sirius
Projects
No open projects
Web Tier Team
  
Awaiting triage
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Port MYFACES-4606 (Issuing Element Not Found in Request Parameter Map for Ajax Requests) to Liberty
5 participants
@volosied @LibbyBot @posmith @dmuelle @pnicolucci