3645 sync user during login #5077

kberkos-public · 2018-09-13T18:19:18Z

No description provided.

merging master

LibbyBot · 2018-09-13T18:19:29Z

Code analysis and actions

DO NOT DELETE THIS COMMENT.

3 product code files were changed.
Please describe in a separate comment how you tested your changes.

kberkos-public · 2018-09-13T18:20:06Z

#3645

…o we can remove the user id from the login thread

kaczyns

Kyle - thanks for making these changes. I'd like Teddy to take a look at this and be the approver. It all looks fine to me, but I am not as familiar with the overall security code and I want to make sure that these changes are not going to break some other part of the security code. I'd also like to talk with you about the FAT tests since those would be delivered separately.

kaczyns · 2018-10-16T14:29:53Z

dev/com.ibm.ws.webcontainer.security/src/com/ibm/ws/webcontainer/security/AuthenticateApi.java

@@ -496,6 +505,17 @@ private void setSubjectAndCookies(HttpServletRequest req, HttpServletResponse re
        if (addSSOCookie) {
            ssoCookieHelper.addSSOCookiesToResponse(subject, req, resp);
        }
+        try {
+            Object loginToken = ThreadIdentityManager.setAppThreadIdentity(subject);
+            WebSecurityContext webSecurityContext = (WebSecurityContext) SRTServletRequestUtils.getPrivateAttribute(req, "SECURITY_CONTEXT");


Seems there should be a constant here for the "SECURITY_CONTEXT" string

kaczyns · 2018-10-16T14:32:53Z

...bcontainer.security/src/com/ibm/ws/webcontainer/security/WebAppSecurityCollaboratorImpl.java

@@ -567,8 +576,10 @@ public Object preInvoke(HttpServletRequest req, HttpServletResponse resp, String
                performSecurityChecks(req, resp, receivedSubject, webSecurityContext);
            }

-            extraAuditData.put("HTTP_SERVLET_REQUEST", req);


I was wondering why the extra audit data was deleted as this doesn't seem to have anything to do with the sync to thread changes, but then again I don't know much about these parts so maybe it was necessary =)

teddyjtorres

It looks good. Please address comments.

...bcontainer.security/src/com/ibm/ws/webcontainer/security/WebAppSecurityCollaboratorImpl.java

Fast-forwarding branch

…mercial liberty delivery

kberkos-public · 2018-11-26T21:20:49Z

#build

LibbyBot · 2018-11-26T21:20:55Z

Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_x2opYPG4Eei52rYPrqOLXw

Target locations of links might be accessible only to IBM employees.

kberkos-public · 2018-11-27T21:13:00Z

#build

LibbyBot · 2018-11-27T21:13:06Z

Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_2dN2EPKAEei52rYPrqOLXw

Target locations of links might be accessible only to IBM employees.

LibbyBot · 2018-11-28T07:31:55Z

The build kberkos-public-5077-20181127-2120
https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_2dN2EPKAEei52rYPrqOLXw
completed and has errors or failures.

kberkos-public · 2018-11-28T16:38:05Z

#build

LibbyBot · 2018-11-28T16:38:11Z

Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_nJQmwPMjEei52rYPrqOLXw

Target locations of links might be accessible only to IBM employees.

LibbyBot · 2018-11-29T01:36:56Z

The build kberkos-public-5077-20181128-1648
https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_nJQmwPMjEei52rYPrqOLXw
completed and has errors or failures.

kberkos-public · 2018-11-30T17:49:37Z

#build

LibbyBot · 2018-11-30T17:49:40Z

Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_7hukgPS_Eei52rYPrqOLXw

Target locations of links might be accessible only to IBM employees.

LibbyBot · 2018-12-01T09:58:25Z

The build kberkos-public-5077-20181130-1826
https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_7hukgPS_Eei52rYPrqOLXw
completed and has errors or failures.

kaczyns

The last build contained only previously-reported defects, or unrelated timing problems. I am approving the PR.

kberkos-public added 2 commits September 12, 2018 14:33

getting things started

047d292

Merge branch 'master' into 3645_sync-user-during-login

a42189b

merging master

LibbyBot added the CLA Signed label Sep 13, 2018

kberkos-public added release bug This bug is present in a released version of Open Liberty and removed CLA Signed labels Sep 13, 2018

kberkos-public self-assigned this Sep 13, 2018

kberkos-public mentioned this pull request Sep 13, 2018

User ID is not synced to the thread during HttpServletRequest.login() #3645

Closed

kberkos-public added 6 commits September 19, 2018 10:33

Fixed post invoke call, modified login

9f8ac20

Updated AuthenticateApi to take the unauthenticated subject service s…

9a82649

…o we can remove the user id from the login thread

fixed abstract method error in server logs during test

13b2dfe

removed commented out code

7fe6135

Fix null pointer in pre invoke, remove unnecessary code in post invoke

31b3503

updated copyrights

0d15249

kberkos-public requested review from teddyjtorres and kaczyns October 10, 2018 14:57

kaczyns reviewed Oct 16, 2018

View reviewed changes

Tim K. code review changes

6185172

teddyjtorres reviewed Nov 6, 2018

View reviewed changes

...bcontainer.security/src/com/ibm/ws/webcontainer/security/WebAppSecurityCollaboratorImpl.java Outdated Show resolved Hide resolved

...bcontainer.security/src/com/ibm/ws/webcontainer/security/WebAppSecurityCollaboratorImpl.java Outdated Show resolved Hide resolved

kberkos-public added 3 commits November 13, 2018 15:12

Teddy code review changes

8f874fc

Merge branch 'master' into 3645_sync-user-during-login

2d0c0f1

Fast-forwarding branch

All necessary changes for original defect, as well as staging for com…

3538e92

…mercial liberty delivery

fixing open liberty junit test failures

9c7a645

Fixed null pointer in junit tests

99da2c4

kberkos-public added 2 commits November 30, 2018 10:16

Merge branch 'master' into 3645_sync-user-during-login

4e748cf

Actually fixed null pointer

888d3c2

kaczyns approved these changes Dec 3, 2018

View reviewed changes

kaczyns merged commit 0bc91f9 into OpenLiberty:integration Dec 3, 2018

kberkos-public mentioned this pull request Dec 7, 2018

cleaning up old code #5984

Merged

LibbyBot added the release:19001 label Jan 26, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

3645 sync user during login #5077

3645 sync user during login #5077

kberkos-public commented Sep 13, 2018

LibbyBot commented Sep 13, 2018

kberkos-public commented Sep 13, 2018 •

edited by jjiwooLim

Loading

kaczyns left a comment

kaczyns Oct 16, 2018

kaczyns Oct 16, 2018

teddyjtorres left a comment

kberkos-public commented Nov 26, 2018

LibbyBot commented Nov 26, 2018

kberkos-public commented Nov 27, 2018

LibbyBot commented Nov 27, 2018

LibbyBot commented Nov 28, 2018

kberkos-public commented Nov 28, 2018

LibbyBot commented Nov 28, 2018

LibbyBot commented Nov 29, 2018

kberkos-public commented Nov 30, 2018

LibbyBot commented Nov 30, 2018

LibbyBot commented Dec 1, 2018

kaczyns left a comment

3645 sync user during login #5077

3645 sync user during login #5077

Conversation

kberkos-public commented Sep 13, 2018

LibbyBot commented Sep 13, 2018

Code analysis and actions

kberkos-public commented Sep 13, 2018 • edited by jjiwooLim Loading

kaczyns left a comment

Choose a reason for hiding this comment

kaczyns Oct 16, 2018

Choose a reason for hiding this comment

kaczyns Oct 16, 2018

Choose a reason for hiding this comment

teddyjtorres left a comment

Choose a reason for hiding this comment

kberkos-public commented Nov 26, 2018

LibbyBot commented Nov 26, 2018

kberkos-public commented Nov 27, 2018

LibbyBot commented Nov 27, 2018

LibbyBot commented Nov 28, 2018

kberkos-public commented Nov 28, 2018

LibbyBot commented Nov 28, 2018

LibbyBot commented Nov 29, 2018

kberkos-public commented Nov 30, 2018

LibbyBot commented Nov 30, 2018

LibbyBot commented Dec 1, 2018

kaczyns left a comment

Choose a reason for hiding this comment

kberkos-public commented Sep 13, 2018 •

edited by jjiwooLim

Loading