Handle Tx Recovery log bundle startup variations #5121
Conversation
Code analysis and actionsDO NOT DELETE THIS COMMENT.
|
|
#build |
|
Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_PaQIQLtTEeieisOzGH_nZQ Target locations of links might be accessible only to IBM employees. |
|
The build neilgsyoung-5121-20180918-1608 |
|
#build |
|
Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_SWhwIMAJEei9re3pB293Wg Target locations of links might be accessible only to IBM employees. |
|
The build neilgsyoung-5121-20180924-1602 |
|
#build |
|
Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_beJ-wMDUEei9re3pB293Wg Target locations of links might be accessible only to IBM employees. |
|
The build neilgsyoung-5121-20180925-1616 |
|
#build |
|
Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_AB2SAMGBEei9re3pB293Wg Target locations of links might be accessible only to IBM employees. |
|
The build neilgsyoung-5121-20180926-1250 |
|
#build |
|
Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_Rs8QIMJEEei9re3pB293Wg Target locations of links might be accessible only to IBM employees. |
|
The build neilgsyoung-5121-20180927-1208 |
|
#build |
|
Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_XypgoMZWEeiA6ZPkBDHUqw Target locations of links might be accessible only to IBM employees. |
|
The build neilgsyoung-5121-20181002-1634 |
|
#build |
|
Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_QnyukMZ5EeiA6ZPkBDHUqw Target locations of links might be accessible only to IBM employees. |
|
The build neilgsyoung-5121-20181002-2034 |
|
#build |
|
Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_FxejUMbcEeiA6ZPkBDHUqw Target locations of links might be accessible only to IBM employees. |
|
The build neilgsyoung-5121-20181003-0822 |
neilgsyoung
force-pushed
the
5119-txreclogbundles
branch
from
fb930c2
to
4d76dbf
Compare
|
#build |
|
Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_Wj1qQMb9EeiA6ZPkBDHUqw Target locations of links might be accessible only to IBM employees. |
|
#build |
|
Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_34iBsAOQEemkvu7GUlsKfw Target locations of links might be accessible only to IBM employees. |
|
The build neilgsyoung-5121-20181219-1431 |
|
#build |
|
Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_3kD2oAPJEemkvu7GUlsKfw Target locations of links might be accessible only to IBM employees. |
|
The build neilgsyoung-5121-20181219-2115 |
neilgsyoung
force-pushed
the
5119-txreclogbundles
branch
2 times, most recently
from
ea6bfce
to
3b8831d
Compare
|
#build |
|
Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_hu8e4ARVEemkvu7GUlsKfw Target locations of links might be accessible only to IBM employees. |
|
The build neilgsyoung-5121-20181220-1416 |
|
#build |
|
Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_VDr9UA5SEemzked6cGmzzw Target locations of links might be accessible only to IBM employees. |
|
The build neilgsyoung-5121-20190102-0702 |
|
The build neilgsyoung-5121-20190103-1229 |
|
#build |
|
Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_H2-IMBo2EemsU9nTXOm12w Target locations of links might be accessible only to IBM employees. |
|
The build neilgsyoung-5121-20190117-1008 |
|
#build |
|
Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_FIBrAB4uEemxE4V1kbLZCQ Target locations of links might be accessible only to IBM employees. |
|
Your Open Liberty build results are at http://public.dhe.ibm.com/ibmdl/export/pub/software/openliberty/runtime/personal/_FIBrAB4uEemxE4V1kbLZCQ. There might be a brief delay before results are available. |
More rework on data source access even more rework of data source access Rework data source access stage 4 Rework data source access stage 5 Rework data source access stage 6 Rework data source access stage 7 Rework data source access stage 8 Rework data source access stage 9 Rework data source access stage 10 Rework data source access stage 11 Rework data source access stage 12 Rework data source access stage 13 Rework data source access stage 14 Rework data source access stage 15 Rework tx bundle startup Fix intermittent test issues and simplify JTMConfigurationProvider move service ref activate to setDataSourceFactory method correct unsetDataSourceFactory method
neilgsyoung
force-pushed
the
5119-txreclogbundles
branch
from
3b8831d
to
1c0a3b3
Compare
|
#build |
|
Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_mA88MiAYEemxE4V1kbLZCQ Target locations of links might be accessible only to IBM employees. |
|
Your Open Liberty build results are at http://public.dhe.ibm.com/ibmdl/export/pub/software/openliberty/runtime/personal/_mA88MiAYEemxE4V1kbLZCQ. There might be a brief delay before results are available. |
|
The build neilgsyoung-5121-20190124-2150 |
fixes #5119
The Changes under this PR include:
1/ KEY CHANGE The TMRecoveryService class was introduced to support a new Declarative Service to break a potential circular reference between the TransactionManagerService and jdbc's DataSourceService which are mutually dependent.
The mutual dependency arises in the situation where the Transaction service is logging to an RDBMS. The DataSourceService (actually related Connection Manager Services) require a Transaction Manager, the Transaction Manager requires a DataSourceService through which to write its logs.
The new TMRecoveryService requires that the TransactionManagerService is available (as does the DataSourceService). Once it is available, Transaction Recovery can proceed as the DataSourceService can, if necessary be activated. Previously, intermittently, DS would attempt to activate the DataSourceService in the context of TransactionManagerService activation. That would fail with a DS Circular Reference error.
2/ Some classes have merely been reformatted. They were changed during the course of investigative work but the change to standard OL Java formatting is retained. The classes are,
SQLNonTransactionalDataSource.java, CustomLogProperties.java, FileSharedServerLeaseLog.java, RecoveryAgent.java, RecoveryLogManager.java, RecoveryLogManagerImpl.java, LocalTranTest.java, com.ibm.rls.jdbc.bnd
3/ There is a requirement to lookup the DS Services Registry during recovery (see XARecoveryDataHelper.lookupXAResourceFactory()). Any bundle context will do for the lookup so allow getBundleContext() method in TxTMHelper to be overridden in the EmbeddedTMHelper class in the ws.tx.embeddable bundle so that if that bundle has started before the tx.jta bundle then Services can be found. In testing, I found that sometimes the tx.jta bundle had not started wheras the ws.tx.embeddable bundle had started.
4/ Make TxTMHelper (and the ws.tx.embeddable bnd.bnd) the focus for DS Service availability for recovery, thus allowing it to control when recovery starts based on Service availability.
5/ Make RecLogServiceImpl the implementor of the DS RecoveryLog Service and allow it to determine that the Recoverylog bundle is ready to start recovery. Previously this was only part OSGi bundlerised and recovery could be started before the Recoverylog bundle had started.
6/ Add a new waitForRecovery test (note the flag is currently set to FALSE).
7/ Add the ported cloud sim FAT tests ported from Commercial Liberty.