Call Class.forName() within doPrivileged block from WASURLObjectFactoryFinder #7521
Conversation
joe-chacko
added
the
release bug
Code analysis and actionsDO NOT DELETE THIS COMMENT.
|
|
#build |
|
Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_8eCisHabEemWNMQzD7Qc1Q Target locations of links might be accessible only to IBM employees. |
joe-chacko
force-pushed
the
assert-privileges-to-retrieve-object-factory-class
branch
from
56e9f44
to
0efd8bd
Compare
|
Your Open Liberty build results are ready for viewing.
|
| } catch (ClassNotFoundException e) { | ||
| // auto-ffdc | ||
| } | ||
| } |
There was a problem hiding this comment.
When I build locally with Java11, it made me add a return on findFactory (I added a return null at the end).
There was a problem hiding this comment.
Thanks — an issue with my IDE prevented it flagging some errors. I found them in the build and resolved them.
|
I copied the changes locally so I can run the failing ldap_fat test (LDAPReferralTest). I had to make some changes to WASURLObjectFactoryFinder to get it to build -- I am building with Java11. Added review comments. After I made those changes, Java2 issue was resolved. |
joe-chacko
force-pushed
the
assert-privileges-to-retrieve-object-factory-class
branch
from
0efd8bd
to
dcf743b
Compare
joe-chacko
force-pushed
the
assert-privileges-to-retrieve-object-factory-class
branch
from
dcf743b
to
d66e01e
Compare
|
#build |
|
Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_T7btEHdTEemWNcQzD7Qc1Q Target locations of links might be accessible only to IBM employees. |
|
Your Open Liberty build results are ready for viewing.
|
|
The build chackoj-7521-20190515-2200 |
|
|
||
| @FFDCIgnore(PrivilegedActionException.class) | ||
| static Constructor<? extends ObjectFactory> getConstructor(ClassLoader tccl, String className) throws Exception { |
There was a problem hiding this comment.
When I build locally with Java11, it made me add finals on getConstructor variables.
No description provided.