Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use JNoSQL instead of manual parser #6

Open
otaviojava opened this issue Oct 7, 2017 · 1 comment
Open

Use JNoSQL instead of manual parser #6

otaviojava opened this issue Oct 7, 2017 · 1 comment

Comments

@otaviojava
Copy link

On the JavaOne 2017, I saw the demo and I liked, however, I could see the demo is using a parser manually.

Can I create a PR that uses JNoSQL instead of the driver?

We also did same presentations at JavaOne:

Let me know, I'm glad to help.

@kaczyns
Copy link
Contributor

kaczyns commented Oct 18, 2017

Hi Otavio - thanks for your feedback on the demo, we're glad that you liked it. Sure you can create a PR that uses JNoSQL. There will be some paperwork required before we can merge it in, but hopefully it's not a problem:

  • Need to sign our contributor license agreement (CLA). Can read more about that here
  • The JNoSQL license needs to be reviewed. It looks like you use the Apache 2.0 license so there should be no issue here.
  • Our legal team needs to review any libraries that you use. Again I don't see any issue here since JNoSQL uses the Apache license, so this should just be a formality.
  • Someone on our development team needs to review the PR. I promise this will happen more quickly than my initial reply to you!

Thanks for your interest and I look forward to the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants