Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Dynamic variable hierarchy with better sub-level names #306

Open
jkirk5 opened this issue Jun 5, 2024 · 0 comments
Open

Update Dynamic variable hierarchy with better sub-level names #306

jkirk5 opened this issue Jun 5, 2024 · 0 comments
Labels
code cleanup Code cleanup, refactoring, or similar helpful reorganization good first issue Good for newcomers

Comments

@jkirk5
Copy link
Contributor

jkirk5 commented Jun 5, 2024

Desired capability or behavior.

Dynamic currently has one "sub-level", Mission, which doesn't helpfully describe or break up the variables in Dynamic. I suggest updating the second layer of the hierarchy to be more descriptive. Possible refactored subclasses could include:

  • atmosphere: values related to freestream and atmospheric conditions, such as altitude, density, Mach, etc.
  • vehicle: values related to the vehicle, things the vehicle passes to the EOMs, such as total thrust, lift, mass, etc. - maybe flight path angle & AOA?
  • engine: per-engine model values such as throttle, thrust, fuel flow, RPM, etc. Could be added as a third layer under vehicle for better clarity

Is your feature request related to a problem? Please describe.

No response

Associated Bug Report

No response

@jkirk5 jkirk5 added good first issue Good for newcomers code cleanup Code cleanup, refactoring, or similar helpful reorganization labels Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code cleanup Code cleanup, refactoring, or similar helpful reorganization good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant