Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Aviary engine deck format with optional delineation of dependent and independent variables #309

Open
jkirk5 opened this issue Jun 5, 2024 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@jkirk5
Copy link
Contributor

jkirk5 commented Jun 5, 2024

Desired capability or behavior.

Support the addition of a blank column in-between independent and dependent variables to allow users to communicate which variables their specific engine supports. If the blank column isn't provided, assume the default independent variables (Mach, alt, throttle)

The code to actually generate the interpolators will need to be updated in engine_deck.py with this updated format - this is also a good place to start using the interpolator builder utils that are available for aero (they dynamically create an interpolator object based on provided independent and dependent variable data)

Is your feature request related to a problem? Please describe.

No response

Associated Bug Report

No response

@jkirk5 jkirk5 self-assigned this Jun 13, 2024
@jkirk5 jkirk5 added the enhancement New feature or request label Jun 13, 2024
@jkirk5
Copy link
Contributor Author

jkirk5 commented Jun 26, 2024

After further discussion with team, the blank column may be replaced with specifying variable type through the header, or a second row of headers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant