Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible code duplication in propulsion #315

Open
jkirk5 opened this issue Jun 10, 2024 · 0 comments
Open

Possible code duplication in propulsion #315

jkirk5 opened this issue Jun 10, 2024 · 0 comments
Labels
code cleanup code cleanup, refactoring, or similar helpful reorganization

Comments

@jkirk5
Copy link
Contributor

jkirk5 commented Jun 10, 2024

Desired capability or behavior.

There are several places in propulsion where the code traverses a section of the variable hierarchy and assembles an AviaryValues object from multiple sources, typically from another object and the metadata defaults.

Each application is different but there may be common pieces that can be spun off into a utility function. Some files where this happens include propulsion.utils.py, engine_deck.py, engine_model.py, aviary_values.py

Is your feature request related to a problem? Please describe.

No response

Associated Bug Report

No response

@jkirk5 jkirk5 added the code cleanup code cleanup, refactoring, or similar helpful reorganization label Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code cleanup code cleanup, refactoring, or similar helpful reorganization
Projects
None yet
Development

No branches or pull requests

1 participant