Minor tweaks to docs and naming #22
Conversation
| @@ -226,14 +226,6 @@ def load_inputs(self, input_filename, engine_builder=None): | |||
| aviary_inputs.set_val(Mission.Summary.GROSS_MASS, | |||
| val=self.initial_guesses['actual_takeoff_mass'], units='lbm') | |||
|
|
|||
| # Commonly referenced values | |||
| self.enable_engine_sizing = aviary_inputs.get_val( | |||
There was a problem hiding this comment.
Apparently they were not commonly referenced.
| self.cruise_alt = aviary_inputs.get_val( | ||
| Mission.Design.CRUISE_ALTITUDE, units='ft') | ||
| self.problem_type = aviary_inputs.get_val('problem_type') |
There was a problem hiding this comment.
I believe these two are actually referenced elsewhere.
There was a problem hiding this comment.
cruise_alt and problem_type are used elsewhere, these should not be removed
There was a problem hiding this comment.
For both of these the values are later overwritten; the values saved in load_inputs are replaced by values read in in _add_gasp_takeoff_systems and add_design_variables. I believe it is fine to be removed from load_inputs based on this. Do you see a reason to keep these value instantiations as they stand?
There was a problem hiding this comment.
as long as that happens before the phases are added to the problem, that should be fine
| self.cruise_alt = aviary_inputs.get_val( | ||
| Mission.Design.CRUISE_ALTITUDE, units='ft') | ||
| self.problem_type = aviary_inputs.get_val('problem_type') |
There was a problem hiding this comment.
cruise_alt and problem_type are used elsewhere, these should not be removed
Summary
Minor changes to:
mission_methodandmission_originintomission_methodRelated Issues
Backwards incompatibilities
None
New Dependencies
None