Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deepcopy of phase_info from the level 2 interface. #44

Merged
merged 5 commits into from
Jan 9, 2024

Conversation

Kenneth-T-Moore
Copy link
Member

Summary

Removed the deepcopy of phase_info from the level 2 interface to prevent the potential problems when copying local attributes that aren't copyable.

  • Update several tests to do a local deepcopy of phase_info so that the aviary default versions aren't modified during testing.

Related Issues

Backwards incompatibilities

None

New Dependencies

None

Copy link
Member

@johnjasa johnjasa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this, Ken!

@Kenneth-T-Moore
Copy link
Member Author

I made some changes to remove all of the intentional changes that level 2 makes to the phase_info object (essentially removed all the dictionary pops.)

@johnjasa johnjasa added this pull request to the merge queue Jan 9, 2024
Merged via the queue into OpenMDAO:main with commit 091fb86 Jan 9, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deepcopy of phase_info in AviaryProblem can cause problems.
3 participants