Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved OAS example to a notebook #45

Merged
merged 8 commits into from
Jan 11, 2024
Merged

Conversation

johnjasa
Copy link
Member

@johnjasa johnjasa commented Jan 8, 2024

Summary

Converted the existing OAS subsystem docs from .md to .ipynb.
Added a few notes and broke up paragraphs for clarity.
No major content changes.

Related Issues

  • Resolves #

Backwards incompatibilities

None

New Dependencies

None

@jdgratz10 jdgratz10 self-assigned this Jan 11, 2024
"Other Aviary variables can also be added as additional inputs based on user needs.\n",
"\n",
"```{note}\n",
"Some modifications of the [OAS_wing_weight_analysis](https://github.com/OpenMDAO/om-Aviary/blob/main/aviary/external_subsystems/OAS_weight/OAS_wing_weight_analysis.py) code may be necessary to add new inputs not already defined.\n",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"may be necessary" or "will be necessary"?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changed, thanks

Copy link
Member

@Kenneth-T-Moore Kenneth-T-Moore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. I didn't review the content too deeply, because it is strictly a move from md to ipynb, but I have a small comment on one of the added notes.

@jdgratz10 jdgratz10 added this pull request to the merge queue Jan 11, 2024
Merged via the queue into OpenMDAO:main with commit 37a745c Jan 11, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants