-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Moved OAS example to a notebook #45
Conversation
"Other Aviary variables can also be added as additional inputs based on user needs.\n", | ||
"\n", | ||
"```{note}\n", | ||
"Some modifications of the [OAS_wing_weight_analysis](https://github.com/OpenMDAO/om-Aviary/blob/main/aviary/external_subsystems/OAS_weight/OAS_wing_weight_analysis.py) code may be necessary to add new inputs not already defined.\n", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"may be necessary" or "will be necessary"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changed, thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good. I didn't review the content too deeply, because it is strictly a move from md to ipynb, but I have a small comment on one of the added notes.
Summary
Converted the existing OAS subsystem docs from .md to .ipynb.
Added a few notes and broke up paragraphs for clarity.
No major content changes.
Related Issues
Backwards incompatibilities
None
New Dependencies
None