Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

conda builds not working anymore #6514

Open
jpfeuffer opened this issue Nov 29, 2022 · 28 comments
Open

conda builds not working anymore #6514

jpfeuffer opened this issue Nov 29, 2022 · 28 comments
Assignees
Labels
major critical issues that are important to fix

Comments

@jpfeuffer
Copy link
Contributor

https://abibuilder.cs.uni-tuebingen.de/jenkins/job/openms/job/ntly/job/conda/475/console

no idea why.

@poshul poshul closed this as completed Dec 1, 2022
@jpfeuffer jpfeuffer reopened this Dec 1, 2022
@jpfeuffer
Copy link
Contributor Author

Issue nr2: our builds do not show the correct outcome

Mamba failed to solve:
 - pandas
 - boost-cpp 1.74.0.*
 - python 3.7.* *_cpython
 - numpy 1.17.*
 - autowrap >=0.22.10
 - qt 5.12.*
 - wheel
 - libgcc-ng >=12
 - cython >=0.25.2
 - xerces-c 3.2.*
 - pip
 - libstdcxx-ng >=12
 - libsvm 3.21.*
 - setuptools
 - libopenms 3.0.0dev

with channels:

The reported errors are:
- Encountered problems while solving:
-   - nothing provides requested libopenms 3.0.0dev
- 
Returning non-final recipe for pyopenms-3.0.0dev-py37_0; one or more dependencies was unsatisfiable:
19:01:25 CONDA_BUILD WARNING Returning non-final recipe for pyopenms-3.0.0dev-py37_0; one or more dependencies was unsatisfiable:
Reloading output folder: /home/builder/mambaforge/envs/bioconda/conda-bld
Transaction

@poshul
Copy link
Collaborator

poshul commented Dec 1, 2022

Where do you see those errors? I see https://abibuilder.cs.uni-tuebingen.de/jenkins/job/openms/job/ntly/job/conda/477/ looking successful.

@timosachsenberg
Copy link
Contributor

its in the console output

@timosachsenberg
Copy link
Contributor

fixed with:
OpenMS/bioconda-recipes#4

@jpfeuffer
Copy link
Contributor Author

TODO:

  • rewrite Jenkins script to save the exit code of the builds and report accordingly.
  • build more python versions

@timosachsenberg
Copy link
Contributor

btw I asked Björn and he said that he thinks you need to specify python versions you want to build... there is no shortcut for building a range of python verison

@jpfeuffer
Copy link
Contributor Author

Can you check if you can read that from somewhere in the repo. Due to issues with the nightly wheels and different versions on Ubuntu,macOS,Win, I would like to fix a supported version file somewhere

@jpfeuffer
Copy link
Contributor Author

For the time being add 3.9, 3.10, 3.11

@jpfeuffer jpfeuffer added major critical issues that are important to fix and removed blocker labels Dec 22, 2022
@jpfeuffer
Copy link
Contributor Author

Reduced to "major". It works now but the build statuses are still wrong.

@jpfeuffer jpfeuffer mentioned this issue Jan 17, 2023
6 tasks
@timosachsenberg

This comment was marked as outdated.

@jpfeuffer

This comment was marked as outdated.

@timosachsenberg

This comment was marked as off-topic.

@jpfeuffer
Copy link
Contributor Author

Weird, tells me sth different:
openms-meta built: 1
pyopenms built: 1
upload: 0

@timosachsenberg

This comment was marked as outdated.

@jpfeuffer
Copy link
Contributor Author

yes, as discussed because bioconda build is bugged

@jpfeuffer
Copy link
Contributor Author

jpfeuffer commented Feb 7, 2023

06:55:31 BIOCONDA ERROR BUILD FAILED: the built package /home/builder/mambaforge/envs/bioconda/conda-bld/linux-64/pyopenms-3.0.0dev-py310h4b47abe_0.tar.bz2 cannot be found
it looks in the wrong folder

@timosachsenberg
Copy link
Contributor

but it seems to upload it???

@jpfeuffer
Copy link
Contributor Author

yes because it's bugged. bioconda build does not do the upload.

@timosachsenberg timosachsenberg removed their assignment Feb 7, 2023
@jpfeuffer
Copy link
Contributor Author

Someone NEEDS to file a bug report.

@jpfeuffer
Copy link
Contributor Author

Or you parse the logs and ignore this specific error.

@bernt-matthias
Copy link
Contributor

Wild guess: conda's has a new package format? Packages now end with .conda.

@jpfeuffer
Copy link
Contributor Author

jpfeuffer commented Feb 8, 2023

Hmm good guess, but it failed since years. It never worked to build inside a container when specifying you own repository.

Your guess will probably lead to additional trouble since we did not know about it.

@poshul
Copy link
Collaborator

poshul commented Feb 13, 2023

Timo has submitted a bug report. In the meantime I just created a soft-link between the directory that conda expects it to be in, and where it actually is. This resolves the issue for now.

@poshul poshul closed this as completed Feb 13, 2023
@jpfeuffer jpfeuffer reopened this Feb 14, 2023
@jpfeuffer
Copy link
Contributor Author

This actually broke the builds completely. Seems like the env needs to be empty and due to the soft link, it is not anymore.

@poshul
Copy link
Collaborator

poshul commented Feb 14, 2023

Okay, I've rolled that back. With Timo's update the Job should pass now even if the upload fails. Is that sufficient as a stopgap until we get a response from the bioconda folks?

@poshul poshul removed the blocker label Feb 14, 2023
@jpfeuffer
Copy link
Contributor Author

jpfeuffer commented Feb 14, 2023

But the update from Timo now only checks upload. And upload will always work because there is an artifact from a previous build. So we don't see any failures ever. There must be another way:

  1. Parse logs
  2. make upload fail if build (really) fails (e.g. by checking artifact date or resetting build folder [be careful with that, conda is very picky about folders used as environments])

@poshul
Copy link
Collaborator

poshul commented Mar 3, 2023

@poshul
Copy link
Collaborator

poshul commented Mar 3, 2023

Still need to get bioconda/bioconda-utils#838 merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
major critical issues that are important to fix
Projects
No open projects
Status: Backlog
Status: In Progress
Development

No branches or pull requests

4 participants