Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

final check for TOPP workflow framework #52

Open
axelwalter opened this issue Apr 24, 2024 · 1 comment
Open

final check for TOPP workflow framework #52

axelwalter opened this issue Apr 24, 2024 · 1 comment
Assignees

Comments

@axelwalter
Copy link
Collaborator

Stuff you notice only when using it.

  • parameter types (for instance TOPP tool lists, booleans)
  • log levels (minimal, commands, all (including stdout)
  • summary for selected parameters before running the workflow
  • handling errors (small, insignificant errors cause workflow to stop)

Fixed these issues with the following changes:

StreamlitUI:

show parameter summary (non-defaults) in expander in run section
check if workflow run completes, show error if not
date and time of latest complete run
input_topp:
include_params list for custom param selection
option to display full parameter name (e.g. algorithm : common : param_name)
custom_defaults: overwrite default parameters

ParameterManager:

TOPP boolean params as strings

Logger:

write three log levels to select any time (minimal, commands and execution times, full)

@axelwalter
Copy link
Collaborator Author

TODO: check booleans and flags

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants