Skip to content
This repository has been archived by the owner on Mar 16, 2020. It is now read-only.

[DONT MERGE] WP 4ds loader #5

Merged
merged 2 commits into from Dec 15, 2017
Merged

[DONT MERGE] WP 4ds loader #5

merged 2 commits into from Dec 15, 2017

Conversation

zpl-zak
Copy link
Member

@zpl-zak zpl-zak commented Dec 14, 2017

No description provided.


};

namespace MeshType
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better use typedefs instead of namespace for each enum?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this namespace version equal to enum class ? See http://en.cppreference.com/w/cpp/language/enum

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be, anyway either use the enum class or typedef, that way we won't have a billion namespaces in doxygen docs etc. - I'd go for C++14 features only if there's a clear benefit though, i.e. typedefs might achieve the same while keeping the module working with lower C++ versions.

@drummyfish
Copy link
Contributor

I suppose this is only a first draft, but just to be clear: the code you added should be moved to format_parsers.hpp to a subclass of the format class. That class should then be used in osg_loaders.hpp to get the model data and construct the OSG node.

@drummyfish drummyfish merged commit 106085e into master Dec 15, 2017
@DavoSK DavoSK deleted the DavoSK branch December 16, 2017 15:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants