[PHP 8.2] Warnings in the log files during order placement

[ADDISON74]

Use Magento Sample Pack. Add the following products to the cart "Alice in Wonderland" and "Falling by I am Not Lefthanded".

1. Cart Page - system.log file

2023-04-16T21:54:25+00:00 ERR (3): Deprecated functionality: strlen(): Passing null to parameter #1 ($string) of type string is deprecated  in /var/www/html/app/code/core/Mage/Downloadable/Helper/Catalog/Product/Configuration.php on line 59

2. Checkout - Onepage Billing Information - system.log file

2023-04-16T21:57:35+00:00 ERR (3): Deprecated functionality: Creation of dynamic property Mage_Paypal_Model_Config::$cctypes is deprecated  in /var/www/html/app/code/core/Mage/Paypal/Model/Config.php on line 781

3. Checkout - After placing the order - system.log file

2023-04-16T21:59:48+00:00 ERR (3): Deprecated functionality: trim(): Passing null to parameter #1 ($string) of type string is deprecated  in /var/www/html/app/code/core/Mage/SalesRule/Model/Rule.php on line 203

[fballiano]

Hi @ADDISON74,

1. should be done with Fixed deprecation warning in Mage_Downloadable_Helper_Catalog_Product_Configuration #3187
2. can you check if you still get the error with Fixed logging too many exceptions for payment methods #3181? maybe that fix also fixes this one
3. will do

[fballiano]

3. should be done in Fixed deprecation warning in Mage_SalesRule_Model_Rule #3188

[ADDISON74]

For point 2, in my case #3181 it is not fixing it. Here is the system.log file content with that PR applied. I deleted the duplicated lines. There are more errors after finishing the checkout than I reported before, one is related to Google Analytics.

2023-04-17T14:16:57+00:00 ERR (3): Deprecated functionality: Creation of dynamic property Mage_Paypal_Model_Config::$visible_on_product is deprecated  in /var/www/html/app/code/core/Mage/Paypal/Model/Config.php on line 781
2023-04-17T14:16:57+00:00 ERR (3): Deprecated functionality: Creation of dynamic property Mage_Paypal_Model_Config::$active is deprecated  in /var/www/html/app/code/core/Mage/Paypal/Model/Config.php on line 781

2023-04-17T14:16:58+00:00 ERR (3): Deprecated functionality: imagecolorallocate(): Passing null to parameter #2 ($red) of type int is deprecated  in /var/www/html/lib/Varien/Image/Adapter/Gd2.php on line 276
2023-04-17T14:16:58+00:00 ERR (3): Deprecated functionality: imagecolorallocate(): Passing null to parameter #3 ($green) of type int is deprecated  in /var/www/html/lib/Varien/Image/Adapter/Gd2.php on line 276
2023-04-17T14:16:58+00:00 ERR (3): Deprecated functionality: imagecolorallocate(): Passing null to parameter #4 ($blue) of type int is deprecated  in /var/www/html/lib/Varien/Image/Adapter/Gd2.php on line 276

2023-04-17T14:17:06+00:00 ERR (3): Deprecated functionality: trim(): Passing null to parameter #1 ($string) of type string is deprecated  in /var/www/html/app/code/core/Mage/GiftMessage/Block/Message/Inline.php on line 245

2023-04-17T14:17:33+00:00 ERR (3): Deprecated functionality: Creation of dynamic property Mage_Paypal_Model_Config::$cctypes is deprecated  in /var/www/html/app/code/core/Mage/Paypal/Model/Config.php on line 781

2023-04-17T14:17:41+00:00 ERR (3): Deprecated functionality: strlen(): Passing null to parameter #1 ($string) of type string is deprecated  in /var/www/html/app/code/core/Mage/Downloadable/Helper/Catalog/Product/Configuration.php on line 59

2023-04-17T14:17:48+00:00 ERR (3): Deprecated functionality: strtoupper(): Passing null to parameter #1 ($string) of type string is deprecated  in /var/www/html/app/code/core/Mage/GoogleAnalytics/Block/Ga.php on line 213

[TangLiang]

same issue on OpenMage 20.1.0-rc3

2023-04-21T02:39:29+00:00 ERR (3): Deprecated functionality: Creation of dynamic property Mage_Paypal_Model_Config::$active is deprecated  in /home/wwwroot/lnmp01/domain/xxx.com/web/app/code/core/Mage/Paypal/Model/Config.php on line 782
2023-04-21T02:39:29+00:00 ERR (3): Deprecated functionality: Creation of dynamic property Mage_Paypal_Model_Config::$visible_on_cart is deprecated  in /home/wwwroot/lnmp01/domain/xxx.com/web/app/code/core/Mage/Paypal/Model/Config.php on line 782
2023-04-21T02:39:29+00:00 ERR (3): Deprecated functionality: Creation of dynamic property Mage_Paypal_Model_Config::$active is deprecated  in /home/wwwroot/lnmp01/domain/xxx.com/web/app/code/core/Mage/Paypal/Model/Config.php on line 782
2023-04-21T02:39:29+00:00 ERR (3): Deprecated functionality: Creation of dynamic property Mage_Paypal_Model_Config::$visible_on_cart is deprecated  in /home/wwwroot/lnmp01/domain/xxx.com/web/app/code/core/Mage/Paypal/Model/Config.php on line 782
2023-04-21T02:39:29+00:00 ERR (3): Deprecated functionality: Creation of dynamic property Mage_Paypal_Model_Config::$active is deprecated  in /home/wwwroot/lnmp01/domain/xxx.com/web/app/code/core/Mage/Paypal/Model/Config.php on line 782
2023-04-21T02:39:29+00:00 ERR (3): Deprecated functionality: strtolower(): Passing null to parameter #1 ($string) of type string is deprecated  in /home/wwwroot/lnmp01/domain/xxx.com/web/app/code/core/Mage/Catalog/Helper/Image.php on line 568
2023-04-21T02:39:29+00:00 ERR (3): Deprecated functionality: Creation of dynamic property Mage_Paypal_Model_Config::$visible_on_cart is deprecated  in /home/wwwroot/lnmp01/domain/xxx.com/web/app/code/core/Mage/Paypal/Model/Config.php on line 782
2023-04-21T02:39:29+00:00 ERR (3): Deprecated functionality: Creation of dynamic property Mage_Paypal_Model_Config::$active is deprecated  in /home/wwwroot/lnmp01/domain/xxx.com/web/app/code/core/Mage/Paypal/Model/Config.php on line 782
2023-04-21T02:39:29+00:00 ERR (3): Deprecated functionality: Creation of dynamic property Mage_Paypal_Model_Config::$visible_on_cart is deprecated  in /home/wwwroot/lnmp01/domain/xxx.com/web/app/code/core/Mage/Paypal/Model/Config.php on line 782
2023-04-21T02:39:29+00:00 ERR (3): Deprecated functionality: Creation of dynamic property Mage_Paypal_Model_Config::$active is deprecated  in /home/wwwroot/lnmp01/domain/xxx.com/web/app/code/core/Mage/Paypal/Model/Config.php on line 782

[fballiano]

the paypal one has been fixed for sure, the image.php one should be fixed in #3201

[TangLiang]

[PHP 8.2 - OpenMage 20.1.0-rc3] - this is not related to the current issue.

Deprecated functionality: preg_split(): Passing null to parameter #2 ($subject) of type string is deprecated in /app/code/core/Mage/Core/Helper/String.php on line 251

Deprecated functionality: iconv_strlen(): Passing null to parameter #1 ($string) of type string is deprecated in /app/code/core/Mage/Core/Helper/String.php on line 79

[ADDISON74]

[PHP 8.2] - this is not related to the current issue, but I found it in the system.log file today.

2023-05-13T14:08:02+00:00 ERR (3): Deprecated functionality: strtotime(): Passing null to parameter #1 ($datetime) of type string is deprecated  in /var/www/html/app/code/core/Mage/Cron/Model/Observer.php on line 223

[fballiano]

[PHP 8.2 - OpenMage 20.1.0-rc3] - this is not related to the current issue.

Deprecated functionality: preg_split(): Passing null to parameter #2 ($subject) of type string is deprecated in /app/code/core/Mage/Core/Helper/String.php on line 251

Deprecated functionality: iconv_strlen(): Passing null to parameter #1 ($string) of type string is deprecated in /app/code/core/Mage/Core/Helper/String.php on line 79

this one is tricky, because it comes from the search engine... we shouldn't fix it in those 2 lines but above in the calls stack...

[fballiano]

@TangLiang do you know how to reproduce the problem?

[TangLiang]

@fballiano i just checked,it's cause by the third part extension,it not check the string is empty or exist before call Mage::help('core/string')->splitWords() and Mage::help('core/string')->strlen().
it's not magento bug. so sorry for this

[ADDISON74]

I am going to close this issue because I haven't found any more errors in the OpenMage log files. If they appear, a new report ticket can be created.