Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slow ?trtrs implementation #2251

Closed
thrasibule opened this issue Sep 8, 2019 · 0 comments · Fixed by #2252
Closed

Slow ?trtrs implementation #2251

thrasibule opened this issue Sep 8, 2019 · 0 comments · Fixed by #2252

Comments

@thrasibule
Copy link
Contributor

thrasibule commented Sep 8, 2019

openblas uses the reference implementation which is pretty slow since it uses ?trsm by default which is much slower than ?trsv in case the right hand side only has 1 column. This seems to come up regularly and surprise people (see here for a numpy discussion or here for the same discovery in julia). I noticed ?getrs has an optimized implementation which uses this simple trick (?trsv in case of column vector b, ?trsm otherwise), so I propose to do the same for ?trtrs. Does it make sense?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant