-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SVD convergence error in the presence of nan's #3225
Comments
Bisecting now, suspect it could be one of the recent merges from Reference-LAPACK 3.9.1 |
Right, imported from Reference-LAPACK PR 471 "Handle norm NaN value in xGESDD": |
Argh, so much fun. So not a bug from your perspective, and we should do something LAPACK-version-dependent in NumPy to handle this? |
Not sure if my (frog) perspective counts, I have raised the issue with the more illustrous members of the LAPACK team. Historically, NaN handling appears to have been something that LAPACK has not exactly excelled at. BTW the patch came from a matplotlib guy so at least it seems to stay in the family... |
Is this now "return an error code and propagate the NaN" or "return an error code and not propagate the NaN"? If the latter, that would seem to break backward compatibility. |
Early return with error code set and arguments unchanged, which is what some other LAPACK routines already did. |
Closing here as discussion has taken place in the linked numpy ticket and my impression is that we're agreed to go forward with this change now. |
There seems to be a regression that came in after the
0.3.13
release. In0.3.12
and0.3.13
, this works fine:With
0.3.15
this does not converge. I cannot easily try0.3.14
because it's not packaged on conda-forge. Users and packagers are observing this on multiple macOS and Linux systems, see numpy/numpy#18914 for details.The text was updated successfully, but these errors were encountered: