-
-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cannot Import Library on Mac #288
Comments
Hi @NateSolon, are you by any chance running PyDP in a separate virtual environment to have the packages localized to your PyDP projects? To replicate your issue, I set up a separate new |
Hi @NateSolon ,
Or, what you could do is directly use Google Collab or Docker. |
The simplest solution is to move our release version to OSX 10.13. If someone can edit it on their folk and upload on the test.pypi server to demonstrate if this works, it would be great! Note: In the PR please make sure that the package is tested on OSX 10.13, 10.14 and 10.15 and (or) share the corresponding test pypi project link. |
Just some additional context to help with this ticket. I believe all that is needed is to set the MACOSX_DEPLOYMENT_TARGET environment variable during build time.
I found this project which makes cross platform builds on CI easy: But, looking at the docs and source code it looks like the thing you need is that ENV flag from above: My guess is that xcode build tool chain compiles the MacOS libraries in a way that is backwards compatible to the minimum version set in that env flag. It also looks like for C++17 you might want a minimum of 10.13 which is High Sierra:
So it might be worth going even lower and just seeing what the minimum possible target version is. It's also important to remember that the name of the python wheel indicates the system and architecture versions that it is compatible with so it might also need to be renamed to allow install: |
The OS name seems to be enough for the same. Consider the example of tf here: https://pypi.org/project/tensorflow/#files |
Hi @NateSolon, is this still an issue? |
Description
When I tried to run the carrets_demo notebook, I was unable to import pydp.
How to Reproduce
pip install python-dp
. I also triedpython -m pip install python-dp --force-reinstall
.import pydp as dp
.Expected Behavior
The library imports without error.
System Information
The text was updated successfully, but these errors were encountered: