Skip to content
This repository has been archived by the owner on Feb 16, 2023. It is now read-only.

Make connection speed test optional #557

Closed
cereallarceny opened this issue May 6, 2020 · 2 comments · Fixed by #606
Closed

Make connection speed test optional #557

cereallarceny opened this issue May 6, 2020 · 2 comments · Fixed by #606
Assignees
Labels
Good first issue 🎓 Perfect for beginners, welcome to OpenMined! Priority: 3 - Medium 😒 Should be fixed soon, but there may be other pressing matters that come first Severity: 4 - Low 😎 An aesthetic issue or is the result of non-conformance to a standard Status: Available 👋 Available for assignment, who wants it? Type: Improvement 📈 Performance improvement not introducing a new feature or requiring a major refactor

Comments

@cereallarceny
Copy link
Member

We need to add a field to the response of the authentication call for static FL. If the authentication endpoint returns with a worker_id, then we also need to return with another field: requires_speed_test which will either be true or false, depending on whether or not the server_config sets a minimum download speed OR a minimum upload speed. The requires_speed_test field is entirely dependent on those two server_config variables and cannot be set manually.

@cereallarceny cereallarceny created this issue from a note in Model-centric Federated Learning (To do) May 6, 2020
@cereallarceny cereallarceny added Good first issue 🎓 Perfect for beginners, welcome to OpenMined! Priority: 3 - Medium 😒 Should be fixed soon, but there may be other pressing matters that come first Severity: 4 - Low 😎 An aesthetic issue or is the result of non-conformance to a standard Status: Available 👋 Available for assignment, who wants it? Type: Improvement 📈 Performance improvement not introducing a new feature or requiring a major refactor labels May 26, 2020
@github-actions
Copy link

github-actions bot commented Jul 1, 2020

This issue has been marked stale because it has been open 30 days with no activity. Leave a comment or remove the stale label to unmark it. Otherwise, this will be closed in 7 days.

@github-actions github-actions bot added the stale label Jul 1, 2020
@monuelo monuelo removed the stale label Jul 1, 2020
@cereallarceny cereallarceny assigned monuelo and unassigned Prtfw Jul 7, 2020
@cereallarceny
Copy link
Member Author

Corrected workflow should be:

  1. Worker sends an authentication request with the (optional) auth token, the model name (required), and the model version (optional).
  2. PyGrid authenticates the worker and IF successful, returns a boolean value for the requires_speed_test property and a string value for the worker_id property.
  3. If requires_speed_test was true, they perform that step. If not, see step 4.
  4. Worker makes an FL cycle request, carry on…

@monuelo monuelo moved this from To do to In progress in Model-centric Federated Learning Jul 11, 2020
Model-centric Federated Learning automation moved this from In progress to Done Jul 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Good first issue 🎓 Perfect for beginners, welcome to OpenMined! Priority: 3 - Medium 😒 Should be fixed soon, but there may be other pressing matters that come first Severity: 4 - Low 😎 An aesthetic issue or is the result of non-conformance to a standard Status: Available 👋 Available for assignment, who wants it? Type: Improvement 📈 Performance improvement not introducing a new feature or requiring a major refactor
Development

Successfully merging a pull request may close this issue.

3 participants