Skip to content
This repository has been archived by the owner on Feb 16, 2023. It is now read-only.

Remote Code Execution (Security) #66

Closed
bendecoste opened this issue Feb 20, 2018 · 6 comments
Closed

Remote Code Execution (Security) #66

bendecoste opened this issue Feb 20, 2018 · 6 comments

Comments

@bendecoste
Copy link
Contributor

For full pytorch support we will need remote code execution of arbitrary code (defined by someone who has defined a model)

We will also likely need remote code execution for data adapters, although these are more auditable (would still be nice to have, though)

some things I have considered so far (as well as their downsides)

chroot jail

what it is
Basically we tell a process that /grid/runhere is the root directory and we manually link everything they are allowed to do (basically nothing) this is not that secure because there are ways to break out of it.

docker

We can look into docker, I have read docker is also no truly secure

@bendecoste
Copy link
Contributor Author

related #48 & #58

@Mike96Angelo has experience with remote code execution

@bendecoste
Copy link
Contributor Author

docker

I would also like to stay clean of docker unless necessary. Installation is way easier right now than if we were using docker imo

@iamtrask
Copy link
Member

@iamtrask
Copy link
Member

and then we support specific layer wrappers - aka - "Sequential" and "Recurrent"

@jvmncs
Copy link
Contributor

jvmncs commented Feb 22, 2018

How do we recreate the whole Module from that though?

@jvmncs
Copy link
Contributor

jvmncs commented Mar 20, 2018

Marking this resolved, as the new approach for integrating pytorch allows us to make sure commands we receive are in the local torch module before executing it. This will be actualized with #129, so feel free to direct further discussion there.

@jvmncs jvmncs closed this as completed Mar 20, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants