Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add code coverage to CI #27

Closed
1 of 6 tasks
TTitcombe opened this issue Jun 19, 2020 · 1 comment · Fixed by #29
Closed
1 of 6 tasks

Add code coverage to CI #27

TTitcombe opened this issue Jun 19, 2020 · 1 comment · Fixed by #29
Labels
Good first issue 🎓 Perfect for beginners, welcome to OpenMined! Type: Testing 🧪 Add testing or improving existing testing of a file, feature, or codebase

Comments

@TTitcombe
Copy link
Member

Description

Add codecoverage report to CI

Type of Test

  • Unit test (e.g. checking a loop, method, or function is working as intended)
  • Integration test (e.g. checking if a certain group or set of functionality is working as intended)
  • Regression test (e.g. checking if by adding or removing a module of code allows other systems to continue to function as intended)
  • Stress test (e.g. checking to see how well a system performs under various situations, including heavy usage)
  • Performance test (e.g. checking to see how efficient a system is as performing the intended task)
  • Other...

Expected Behavior

A code coverage step in the test script.
Each PR should generate a report on code coverage.
If coverage goes below 95%, the build should fail

Additional Context

See the PySyft test script

@TTitcombe TTitcombe added Good first issue 🎓 Perfect for beginners, welcome to OpenMined! Type: Testing 🧪 Add testing or improving existing testing of a file, feature, or codebase labels Jun 19, 2020
@pavlos-p
Copy link
Member

pavlos-p commented Jul 1, 2020

@TTitcombe Should we leave this Closed for now, since it has been removed from #23 and re-implement it in the future?

@TTitcombe TTitcombe mentioned this issue Jul 1, 2020
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Good first issue 🎓 Perfect for beginners, welcome to OpenMined! Type: Testing 🧪 Add testing or improving existing testing of a file, feature, or codebase
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants