Skip to content
This repository has been archived by the owner on Oct 17, 2021. It is now read-only.

Renovate Task architecture #11

Merged
merged 9 commits into from Jul 19, 2021
Merged

Renovate Task architecture #11

merged 9 commits into from Jul 19, 2021

Conversation

kanpov
Copy link
Collaborator

@kanpov kanpov commented Jul 19, 2021

The current Task architecture has a few flaws that really need to be fixed.

  • They aren't coroutines, which disables a lot of potential for the GUI
  • They aren't applied everywhere, for example, Manager classes in the launcher
  • They include 3 launch phases (prelaunch, launch and postlaunch), which aren't needed and increase complexity
  • They use contexts as parameters due to the limitations of implementing an interface

This PR aims to fix all of these.

@kanpov kanpov marked this pull request as draft July 19, 2021 05:23
@kanpov
Copy link
Collaborator Author

kanpov commented Jul 19, 2021

This was easier than I thought it would be. Merging this PR and the only thing remaining to do before the vacation is modpack management in the next PR.

@kanpov kanpov marked this pull request as ready for review July 19, 2021 07:57
@kanpov kanpov merged commit 2095e63 into master Jul 19, 2021
@kanpov kanpov added this to Done in MVP Jul 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
MVP
Done
Development

Successfully merging this pull request may close these issues.

None yet

1 participant