Implement and use List.listArrayReverse()

as a short cut for listArray(listReverse(lst))

Compiler/BackEnd/BackendDAETransform.mo

@@ -121,7 +121,7 @@ algorithm
     vlst := list(arrayGet(ass2, e) for e guard(arrayGet(ass2, e) > 0) in elst);
   end for;
 
-  outAcc := listArray(listReverse(acc));
+  outAcc := List.listArrayReverse(acc);
 end eqnAssignmentNonScalar;
 
 public function varAssignmentNonScalar

Compiler/BackEnd/BackendDAEUtil.mo

@@ -2264,10 +2264,8 @@ algorithm
     outIncidenceArrayT := fillincidenceMatrixT(row, row_indices, outIncidenceArrayT);
   end for;
 
-  iarr := Dangerous.listReverseInPlace(iarr);
-  imap := Dangerous.listReverseInPlace(imap);
-  outIncidenceArray := listArray(iarr);
-  omapIncRowEqn := listArray(imap);
+  outIncidenceArray := List.listArrayReverse(iarr);
+  omapIncRowEqn := List.listArrayReverse(imap);
 end incidenceMatrixDispatchScalar;
 
 protected function fillincidenceMatrixT
@@ -3866,7 +3864,7 @@ algorithm
     // index = numberOfEqs (we reach the end)
     case (_, _, _, _, _, _,  false, _, _, _, _, _)
       then
-        (listArray(listReverse(inIncidenceArray)),inIncidenceArrayT,listArray(listReverse(imapEqnIncRow)),listArray(listReverse(imapIncRowEqn)));
+        (List.listArrayReverse(inIncidenceArray),inIncidenceArrayT,List.listArrayReverse(imapEqnIncRow),List.listArrayReverse(imapIncRowEqn));
 
     // index < numberOfEqs
     case (_, _, iArr, _, _, _, true, _, _, _, _ , _)

Compiler/BackEnd/OnRelaxation.mo

@@ -1403,8 +1403,7 @@ algorithm
     outMT := List.fold1(lst, Array.consToElement, i, outMT);
     m := lst::m;
   end for;
-  m := Dangerous.listReverseInPlace(m);
-  outM := listArray(m);
+  outM := List.listArrayReverse(m);
   outMT := mT;
 end getOrphansIncidenceMatrix;
 

Compiler/BackEnd/RemoveSimpleEquations.mo

@@ -465,7 +465,7 @@ protected
 algorithm
   if foundSimple then
     // transform simpleeqns to array
-    simpleeqns := listArray(listReverse(iSimpleeqnslst));
+    simpleeqns := List.listArrayReverse(iSimpleeqnslst);
     // collect and handle sets
     (vars, eqnslst, shared, repl) := handleSets(arrayLength(simpleeqns), 1, simpleeqns, iMT, iUnreplaceable, iVars, iEqnslst, ishared, iRepl);
     // perform replacements and try again
@@ -768,7 +768,7 @@ algorithm
     case (true, _, _, _, _, _, _, _, _, _, _)
       equation
         // transform simpleeqns to array
-        simpleeqns = listArray(listReverse(iSimpleeqnslst));
+        simpleeqns = List.listArrayReverse(iSimpleeqnslst);
         // collect and handle sets
         (vars, eqnslst, shared, repl) = handleSets(arrayLength(simpleeqns), 1, simpleeqns, iMT, iUnreplaceable, iVars, iEqnslst, ishared, iRepl);
         // perform replacements and try again

Compiler/Util/BasePVector.mo

@@ -49,6 +49,7 @@ encapsulated partial package BasePVector
 replaceable type T = Integer; // Should be Any.
 
 protected
+import List;
 import MetaModelica.Dangerous;
 
 uniontype Vector
@@ -155,7 +156,7 @@ algorithm
         e :: rest := rest;
         node_lst := VALUE(e) :: node_lst;
       end for;
-      tail := arrayAppend(tail, listArray(listReverse(node_lst)));
+      tail := arrayAppend(tail, List.listArrayReverse(node_lst));
     end if;
 
     // Keep track of the size so we know where to push new nodes.

Compiler/Util/GraphML.mo

@@ -593,7 +593,7 @@ algorithm
   GRAPHINFO(graphs,graphCount,nodes,nodeCount,edges,edgeCount,attributes,graphNodeKey,graphEdgeKey) := iGraphInfo;
   graphsArr := listArray(graphs);
   nodesArr := listArray(nodes);
-  attributesArr := listArray(listReverse(attributes));
+  attributesArr := List.listArrayReverse(attributes);
   oGraphInfo := GRAPHINFOARR(graphsArr,nodesArr,edges,attributesArr,graphNodeKey,graphEdgeKey);
 end convertToGraphInfoArr;
 

Compiler/Util/List.mo

@@ -96,7 +96,8 @@ encapsulated package List
 "
 
 protected
-import MetaModelica.Dangerous.{listReverseInPlace, arrayGetNoBoundsChecking};
+import MetaModelica.Dangerous.{listReverseInPlace, arrayGetNoBoundsChecking, arrayUpdateNoBoundsChecking, arrayCreateNoInit};
+import MetaModelica.Dangerous;
 
 public function create<T>
   "Creates a list from an element."
@@ -1493,6 +1494,26 @@ algorithm
   end for;
 end transposeList;
 
+public function listArrayReverse<T>
+  input list<T> inLst;
+  output array<T> outArr;
+protected
+  Integer len;
+  T defaultValue;
+algorithm
+  if listEmpty(inLst) then
+    outArr := listArray(inLst);
+    return;
+  end if;
+  len := listLength(inLst);
+  defaultValue::_ := inLst;
+  outArr := arrayCreateNoInit(len,defaultValue);
+  for e in inLst loop
+    arrayUpdateNoBoundsChecking(outArr, len, e);
+    len := len-1;
+  end for;
+end listArrayReverse;
+
 public function setEqualOnTrue<T>
   "Takes two lists and a comparison function over two elements of the lists.
    It returns true if the two sets are equal, false otherwise."