add some exeption handling for torn linear systems

OpenModelica · May 25, 2016 · 59c64ac · 59c64ac
1 parent 087bdd2
commit 59c64ac
Show file tree

Hide file tree

Showing 4 changed files with 20 additions and 1 deletion.
diff --git a/Compiler/BackEnd/SymbolicJacobian.mo b/Compiler/BackEnd/SymbolicJacobian.mo
@@ -3466,6 +3466,16 @@ algorithm
 
 end jacobianConstant;
 
+public function isJacobianGeneric
+  input BackendDAE.Jacobian inJac;
+  output Boolean result;
+algorithm
+  result := match(inJac)
+  case BackendDAE.GENERIC_JACOBIAN() then true;
+  else false;
+  end match;
+end isJacobianGeneric;
+
 protected function varsNotInRelations
   input output DAE.Exp exp;
   output Boolean cont;

diff --git a/Compiler/SimCode/SimCodeUtil.mo b/Compiler/SimCode/SimCodeUtil.mo
@@ -3119,7 +3119,6 @@ algorithm
       then (equations_, equations_, uniqueEqIndex, tempvars, tmpEqSccMapping, tmpBackendMapping);
 
     // TORNSYSTEM
-
     case (BackendDAE.EQSYSTEM(orderedVars=vars, orderedEqs=eqns), _, BackendDAE.TORNSYSTEM(strictTearingSet, casualTearingSet, linear=b, mixedSystem=mixedSystem))
       equation
         if Flags.isSet(Flags.GRAPHML) then
@@ -3404,6 +3403,12 @@ algorithm
      // CASE: linear
      case(true, BackendDAE.EQSYSTEM(orderedVars=vars, orderedEqs=eqns), BackendDAE.SHARED(knownVars=kv)) equation
        BackendDAE.TEARINGSET(tearingvars=tearingVars, residualequations=residualEqns, innerEquations=innerEquations, jac=inJacobian) = strictTearingSet;
+
+       if not SymbolicJacobian.isJacobianGeneric(inJacobian) then
+         Error.addMessage(Error.NO_JACONIAN_TORNLINEAR_SYSTEM, {});
+         fail();
+       end if;
+
        // get tearing vars
        tvars = List.map1r(tearingVars, BackendVariable.getVarAt, vars);
        tvars = List.map(tvars, BackendVariable.transformXToXd);

diff --git a/Compiler/Util/Error.mo b/Compiler/Util/Error.mo
@@ -702,6 +702,9 @@ public constant Message SCANNER_ERROR_LIMIT = MESSAGE(287, SYNTAX(), ERROR(),
   Util.gettext("Additional syntax errors were suppressed."));
 public constant Message INVALID_TIME_SCOPE = MESSAGE(288, TRANSLATION(), ERROR(),
   Util.gettext("Built-in variable 'time' may only be used in a model or block."));
+public constant Message NO_JACONIAN_TORNLINEAR_SYSTEM = MESSAGE(289, SYMBOLIC(), ERROR(),
+  Util.gettext("A torn linear system has no symbolic jacobian and currently there are no means to solve that numerically. Please compile with the module \"calculateStrongComponentJacobians\" to provide symbolic jacobians for torn linear systems."));
+
 public constant Message UNBOUND_PARAMETER_WITH_START_VALUE_WARNING = MESSAGE(499, TRANSLATION(), WARNING(),
   Util.gettext("Parameter %s has no value, and is fixed during initialization (fixed=true), using available start value (start=%s) as default value."));
 public constant Message UNBOUND_PARAMETER_WARNING = MESSAGE(500, TRANSLATION(), WARNING(),

diff --git a/SimulationRuntime/c/simulation/solver/linearSystem.c b/SimulationRuntime/c/simulation/solver/linearSystem.c
@@ -103,6 +103,7 @@ int initializeLinearSystems(DATA *data, threadData_t *threadData)
       if(linsys[i].initialAnalyticalJacobian(data, threadData))
       {
         linsys[i].jacobianIndex = -1;
+        throwStreamPrint(threadData, "Failed to initialize the jacobian for torn linear system %d.", (int)linsys[i].equationIndex);
       }
       nnz = data->simulationInfo->analyticJacobians[linsys[i].jacobianIndex].sparsePattern.numberOfNoneZeros;
       linsys[i].nnz = nnz;