Skip to content

Commit

Permalink
Use the sceneBoundingRect for text shape while exporting as image
Browse files Browse the repository at this point in the history
Fixes ticket:6139
  • Loading branch information
adeas31 committed Oct 9, 2020
1 parent cec2d52 commit d4f127b
Show file tree
Hide file tree
Showing 4 changed files with 2 additions and 16 deletions.
4 changes: 0 additions & 4 deletions OMEdit/OMEditLIB/Annotations/TextAnnotation.cpp
Expand Up @@ -391,10 +391,6 @@ void TextAnnotation::drawTextAnnotaion(QPainter *painter)
// draw the font
if (mpComponent || mappedBoundingRect.width() != 0 || mappedBoundingRect.height() != 0) {
painter->drawText(mappedBoundingRect, StringHandler::getTextAlignment(mHorizontalAlignment) | Qt::AlignVCenter | Qt::TextDontClip, textToDraw);
mExportBoundingRect = painter->boundingRect(mappedBoundingRect, StringHandler::getTextAlignment(mHorizontalAlignment) | Qt::AlignVCenter | Qt::TextDontClip, textToDraw);
if (mpComponent) {
mExportBoundingRect = sceneTransform().mapRect(mExportBoundingRect);
}
}
}

Expand Down
2 changes: 0 additions & 2 deletions OMEdit/OMEditLIB/Annotations/TextAnnotation.h
Expand Up @@ -64,8 +64,6 @@ class TextAnnotation : public ShapeAnnotation
QString getOMCShapeAnnotationWithShapeName() override;
QString getShapeAnnotation() override;
void updateShape(ShapeAnnotation *pShapeAnnotation) override;

QRectF mExportBoundingRect;
private:
Element *mpComponent;

Expand Down
6 changes: 1 addition & 5 deletions OMEdit/OMEditLIB/Element/Element.cpp
Expand Up @@ -953,11 +953,7 @@ QRectF Element::itemsBoundingRect()
rect |= pElement->sceneBoundingRect();
}
foreach (QGraphicsItem *item, mShapesList) {
if (TextAnnotation *pTextAnnotation = dynamic_cast<TextAnnotation*>(item)) {
rect |= pTextAnnotation->mExportBoundingRect;
} else {
rect |= item->sceneBoundingRect();
}
rect |= item->sceneBoundingRect();
}
if (mpNonExistingElementLine->isVisible()) {
rect |= mpNonExistingElementLine->sceneBoundingRect();
Expand Down
6 changes: 1 addition & 5 deletions OMEdit/OMEditLIB/Modeling/ModelWidgetContainer.cpp
Expand Up @@ -1582,11 +1582,7 @@ QRectF GraphicsView::itemsBoundingRect()
rect |= pElement->itemsBoundingRect();
}
foreach (QGraphicsItem *item, mShapesList) {
if (TextAnnotation *pTextAnnotation = dynamic_cast<TextAnnotation*>(item)) {
rect |= pTextAnnotation->mExportBoundingRect;
} else {
rect |= item->sceneBoundingRect();
}
rect |= item->sceneBoundingRect();
}
foreach (QGraphicsItem *item, mConnectionsList) {
rect |= item->sceneBoundingRect();
Expand Down

0 comments on commit d4f127b

Please sign in to comment.