[NF] Compare names when type checking connections.

OMCompiler/Compiler/NFFrontEnd/NFTypeCheck.mo

@@ -2363,6 +2363,12 @@ algorithm
   else
     for c1 in comps1 loop
       c2 :: rest_c2 := rest_c2;
+
+      if InstNode.name(c1) <> InstNode.name(c2) then
+        matchKind := MatchKind.NOT_COMPATIBLE;
+        return;
+      end if;
+
       (_, _, matchKind) := matchTypes(InstNode.getType(c1), InstNode.getType(c2), dummy, allowUnknown);
 
       if matchKind == MatchKind.NOT_COMPATIBLE then

testsuite/flattening/modelica/scodeinst/ConnectInvalidType2.mo

@@ -0,0 +1,33 @@
+// name: ConnectInvalidType2
+// keywords:
+// status: incorrect
+// cflags: -d=newInst
+//
+
+connector C1
+  Real e;
+  flow Real f;
+end C1;
+
+connector C2
+  Real e2;
+  flow Real f2;
+end C2;
+
+model ConnectInvalidType2
+  C1 c1;
+  C2 c2;
+equation
+  connect(c1, c2);
+end ConnectInvalidType2;
+
+// Result:
+// Error processing file: ConnectInvalidType2.mo
+// [flattening/modelica/scodeinst/ConnectInvalidType2.mo:21:3-21:18:writable] Error: The type of variables c1 and c2
+// are inconsistent in connect equations.
+//
+// # Error encountered! Exiting...
+// # Please check the error message and the flags.
+//
+// Execution failed!
+// endResult

testsuite/flattening/modelica/scodeinst/Makefile

@@ -229,6 +229,7 @@ ConnectExternalObject1.mo \
 ConnectInitial.mo \
 ConnectInvalidForm1.mo \
 ConnectInvalidType1.mo \
+ConnectInvalidType2.mo \
 ConnectNonConnector1.mo \
 ConnectNonConnector2.mo \
 ConnectNonConnector3.mo \