Skip to content

Commit

Permalink
ticket:4078
Browse files Browse the repository at this point in the history
Select the frame with single click or with mouse up & down.
  • Loading branch information
adeas31 committed Nov 12, 2016
1 parent b906ae8 commit e4d06b9
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 8 deletions.
13 changes: 6 additions & 7 deletions OMEdit/OMEditGUI/Debugger/StackFrames/StackFramesWidget.cpp
Expand Up @@ -164,7 +164,7 @@ StackFramesTreeWidget::StackFramesTreeWidget(StackFramesWidget *pStackFramesWidg
setContextMenuPolicy(Qt::CustomContextMenu);
createActions();
connect(mpStackFramesWidget->getMainWindow()->getGDBAdapter(), SIGNAL(stackListFrames(GDBMIValue*)), SLOT(createStackFrames(GDBMIValue*)));
connect(this, SIGNAL(itemDoubleClicked(QTreeWidgetItem*,int)), mpStackFramesWidget, SLOT(stackItemDoubleClicked(QTreeWidgetItem*)));
connect(this, SIGNAL(currentItemChanged(QTreeWidgetItem*,QTreeWidgetItem*)), mpStackFramesWidget, SLOT(stackCurrentItemChanged(QTreeWidgetItem*)));
connect(this, SIGNAL(customContextMenuRequested(QPoint)), this, SLOT(showContextMenu(QPoint)));
}

Expand Down Expand Up @@ -209,7 +209,6 @@ void StackFramesTreeWidget::setCurrentStackFrame(QTreeWidgetItem *pQTreeWidgetIt
}
/* set the current item and add icon to it */
mpStackFramesWidget->setSelectedFrame(pStackFrameItem->getLevel().toInt());
setCurrentItem(pStackFrameItem);
pStackFrameItem->setIcon(0, QIcon(":/Resources/icons/next.svg"));
}
}
Expand Down Expand Up @@ -264,7 +263,7 @@ void StackFramesTreeWidget::createStackFrames(GDBMIValue *pGDBMIValue)
/* if we get some frames then make the first enabled one selected and fetch the variables for it. */
for (int i = 0 ; i < topLevelItemCount() ; i++) {
if (!topLevelItem(i)->isDisabled()) {
mpStackFramesWidget->stackItemDoubleClicked(topLevelItem(i));
mpStackFramesWidget->stackCurrentItemChanged(topLevelItem(i));
return;
}
}
Expand Down Expand Up @@ -628,15 +627,15 @@ void StackFramesWidget::fillThreadComboBox(GDBMIValue *pThreadsGDBMIValue, QStri
}

/*!
* \brief StackFramesWidget::stackItemDoubleClicked
* Slot activated when itemDoubleClicked signal of StackFramesTreeWidget is raised.
* \brief StackFramesWidget::stackCurrentItemChanged
* Slot activated when currentItemChanged signal of StackFramesTreeWidget is raised.
* Sends the -stack-list-variables command.
* \param pQTreeWidgetItem
* \return
*/
void StackFramesWidget::stackItemDoubleClicked(QTreeWidgetItem *pQTreeWidgetItem)
void StackFramesWidget::stackCurrentItemChanged(QTreeWidgetItem *pTreeWidgetItem)
{
StackFrameItem *pStackFrameItem = dynamic_cast<StackFrameItem*>(pQTreeWidgetItem);
StackFrameItem *pStackFrameItem = dynamic_cast<StackFrameItem*>(pTreeWidgetItem);
if (pStackFrameItem && !pStackFrameItem->isDisabled()) {
mpStackFramesTreeWidget->setCurrentStackFrame(pStackFrameItem);
QByteArray cmd = CommandFactory::stackListVariables(getSelectedThread(), getSelectedFrame(), "--simple-values");
Expand Down
2 changes: 1 addition & 1 deletion OMEdit/OMEditGUI/Debugger/StackFrames/StackFramesWidget.h
Expand Up @@ -127,7 +127,7 @@ public slots:
void handleInferiorResumed();
void threadChanged(int threadIndex);
void fillThreadComboBox(GDBMIValue *pThreadsGDBMIValue, QString currentThreadId);
void stackItemDoubleClicked(QTreeWidgetItem *pQTreeWidgetItem);
void stackCurrentItemChanged(QTreeWidgetItem *pTreeWidgetItem);
};

#endif // STACKFRAMESWIDGET_H

0 comments on commit e4d06b9

Please sign in to comment.