Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Categorize open-source libraries in OpenModelica for different uses #5726

Closed
OpenModelica-TracImporter opened this issue Jun 27, 2020 · 8 comments
Assignees
Milestone

Comments

@OpenModelica-TracImporter
Copy link
Member

No description provided.

@casella
Copy link
Contributor

casella commented Jan 5, 2022

Original track ticket: https://trac.openmodelica.org/OpenModelica/ticket/5726

@casella casella added this to the 1.19.0 milestone Jan 5, 2022
@casella casella added this to To do in 1.19.0 Release plan via automation Jan 5, 2022
@casella casella self-assigned this Jan 5, 2022
@casella
Copy link
Contributor

casella commented Jan 5, 2022

The categorization is now available in the OMPackageManager, see https://github.com/OpenModelica/OMPackageManager/blob/master/repos.json, with the following categories: fullSupport, partialSupport, experimental, noSupport, obsolete.

The categorization should be reviewed before releasing 1.19.0, based on the latest coverage test results and on the latest status of libraries.

@dietmarw
Copy link
Contributor

dietmarw commented Jan 5, 2022

Is there any documentation resource that specifies the meaning of the categorisation?
For example if I look at a categorisation like:

"support": [
      ["prerelease", "noSupport"],
      [">=1.2.0", "experimental"],
      ["*", "obsolete"]

I'm a bit lost as to what matches obsolete here. Everything?

@casella
Copy link
Contributor

casella commented Jan 5, 2022

Is there any documentation resource that specifies the meaning of the categorisation?

We should definitely have one in a readme.md file, currently the documentation is in the scripts source code and in @sjoelund's head 😄

I understand the items are applied sequentially, so obsolete matches whatever was not matched in the previous two items.

@casella
Copy link
Contributor

casella commented Apr 13, 2022

Is there any documentation resource that specifies the meaning of the categorisation? For example if I look at a categorisation like:

@dietmarw, I just updated the README.md file with some information about that. Please have a look and comment if needed.

@dietmarw
Copy link
Contributor

dietmarw commented Apr 20, 2022

@casella This looks very good. However it would also be good to have the documentation of what "release identifiers" are allowed. The code example uses prerelease, >=...,*. Now what else is legal here? Would > be allowed and how about < and are there other terms than prerelease that can be used? To make it really clear you should list the allowed release identifiers.

@sjoelund
Copy link
Member

@casella This looks very good. However it would also be good to have the documentation of what "release identifiers" are allowed. The code example uses prerelease, >=...,*. Now what else is legal here? Would > be allowed and how about < and are there other terms than prerelease that can be used? To make it really clear you should list the allowed release identifiers.

https://github.com/OpenModelica/OMPackageManager/blob/master/common.py#L16

> and < are not allowed.

Entries beginning with a + are allowed (to mark certain branches unsupported):

["+default.modelica.association", "noSupport"]

Other entries match verbatim.

@casella casella moved this from To do to In progress in 1.19.0 Release plan May 21, 2022
@casella
Copy link
Contributor

casella commented May 21, 2022

@casella casella closed this as completed May 21, 2022
1.19.0 Release plan automation moved this from In progress to Done May 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

No branches or pull requests

4 participants