Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JS-41: fix Helm develop with latest OpenNMS.js changes #166

Merged
merged 2 commits into from Aug 22, 2019

Conversation

RangerRick
Copy link
Contributor

@RangerRick RangerRick commented Aug 21, 2019

Pull Request Check Sheet

  • Have you read and followed our Contribution Guidelines?
  • Have you made an issue in the OpenNMS issue tracker?
    If so, you should:
    1. update the title of this PR to be of the format: ${JIRA-ISSUE-NUMBER}: subject of pull request
    2. update the JIRA link at the bottom of this comment to refer to the real issue number
    3. prefix your commit messages with the issue number, if possible
  • Have you made a comment in that issue which points back to this PR?
  • Have you updated the JIRA link at the bottom of this comment to link to your issue?
  • If this is a new feature, is there documentation?
  • If this is a new feature or substantial change, are there tests that cover it?

Pull Request Process

One or more reviewers should be assigned to each PR.

If you know that a particular person is subject matter expert in the area your PR affects, feel free to assign one or more reviewers when you create this PR, otherwise reviewers will be assigned for you.

Once the reviewer(s) accept the PR and the branch passes continuous integration in Bamboo, the PR is eligible for merge.

At that time, if you have commit access (are an OpenNMS Group employee or a member of the Order of the Green Polo) you are welcome to merge the PR.
Otherwise, a reviewer can merge it for you.

Thanks for taking time to contribute!

External References

Copy link

@j-white j-white left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RangerRick RangerRick merged commit 2852271 into develop Aug 22, 2019
@RangerRick RangerRick deleted the jira/JS-41 branch August 22, 2019 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants