nls + dojo calendar issue

[GordonSmith]

Irrespective of what locales the user has specified in their DojoWebpackPlugin options, all locales must be included for the dojo calendar (dojo/cldr/nls).

I am guessing this is because the various calendars (dojo/cldr/nls/gregorian.js) reference them all specifically.

Steps to reproduce:

• Build sample application with a subset of the locales it references (e.g. "en").
• Open the sample app in a browser configured with "en-gb"

Note:

• It won't fail if opened in a locale that it does not "know" about e.g. "en-ie".

[chuckdumont]

OK, thanks. I think what needs to happen is that the i18n loader needs add dependencies for all available locales that match, with greater specificity, the locales specified in the locales option. Looking into this.

[GordonSmith]

FWIW This is not just limited to calendar I can also reproduce with a bunch of other dijits...

Also worth noting is that: #68 did happen to "fix" this issue, as the nls loader gracefully handles the "missing/undefined" modules by design. (I was a bit surprised that the observed dojo require behaviour was to not fire the callback...).

[chuckdumont]

Before I post a release, please get version 2.1.4-rc1 and verify that it resolves your issue. Thanks.

[GordonSmith]

I will re-test (I had posted some comment on the PR: #72)

[chuckdumont]

OK, I think #74 should fix it. Please try 2.1.4-rc2.

[GordonSmith]

2.1.4-rc2 is working well for all the test scenarios I could think of! thanks.

[chuckdumont]

Great! v2.1.4 has been published. Thanks for all your help.

[GordonSmith]

No, thank you for your help!