Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated dropin deployment doesn't work on Windows while running #24

Closed
jesse-gallagher opened this issue Aug 18, 2019 · 2 comments
Closed
Labels
bug Something isn't working domino

Comments

@jesse-gallagher
Copy link
Member

This is because of how Windows file locking works. Liberty retains a lock on the file while it's running, and so it leads to NIO problems:

[0F10:0007-1360] 08/18/2019 04:57:38 PM  WLP: SEVERE Encountered exception when deploying dropin: java.nio.file.FileSystemException: C:\Domino\wlp\wlp-19.0.0.7\usr\servers\testServer\dropins\openliberty-domino-proxy.war: The process cannot access the file because it is being used by another process.

I'm not sure if there's a good way to fix this. Maybe use File#deleteOnExit on the old file and deploy with a unique name and hope that works. Slightly better could be to do that but also add a flag to delete the file when the runtime is issued a STOP command.

@jesse-gallagher jesse-gallagher added bug Something isn't working domino labels Aug 18, 2019
@jesse-gallagher
Copy link
Member Author

In local testing now, this seems to have improved - it could be that newer builds of Liberty no longer retain locks on dropin WAR files. I'll keep an eye on this, but it may be safe to close.

@jesse-gallagher
Copy link
Member Author

Obviated by #59

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working domino
Projects
None yet
Development

No branches or pull requests

1 participant