Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenNeuro CLI - not skipping uploaded files #1515

Closed
franklin-feingold opened this issue Feb 6, 2020 · 5 comments
Closed

OpenNeuro CLI - not skipping uploaded files #1515

franklin-feingold opened this issue Feb 6, 2020 · 5 comments
Assignees

Comments

@franklin-feingold
Copy link
Contributor

franklin-feingold commented Feb 6, 2020

we are seeing that files uploaded on OpenNeuro are not being skipped in the upload process - this appears to maybe a regression. I can replicate this along with other users

@nellh
Copy link
Contributor

nellh commented Feb 6, 2020

The CLI is missing a parameter required to return the full tree of files since the file tree optimizations were applied, this should be simple to re-enable. It does work for top level files (since those are always returned).

@franklin-feingold
Copy link
Contributor Author

I heard back from a user using Node.js (v12.16.1), npm (v6.14.2), and the cli (v3.13.0) and found that only the top-level files (mentioned previously) are being skipped. Files that are present on the web UI are being retransferred (the user is running against #1513 too)

@snastase
Copy link

snastase commented Mar 5, 2020

I heard back from a user using Node.js (v12.16.1), npm (v6.14.2), and the cli (v3.13.0) and found that only the top-level files (mentioned previously) are being skipped. Files that are present on the web UI are being retransferred (the user is running against #1513 too)

I tried rolling back to openneuro-cli v3.12.9, but it seems to reproduce the same behavior—skips the top-level text files then starts wholesale re-uploading all stimuli and all subjects (most of which are unchanged and already present online).

image

@snastase
Copy link

snastase commented Mar 6, 2020

Some good(?) news: When running this with v3.12.9—although it did not properly recognize existing files—it actually completed the upload of all 345 subjects without any ServerParseError (#1513). However, I'm not yet seeing any new subjects/files reflected on the web UI (after a couple hours).

@nellh
Copy link
Contributor

nellh commented Jun 24, 2020

This was a dataset specific issue with ds002345 originally caused by poor storage performance. We recently deployed a new storage backend that should avoid that going forward. We went back and fixed the metadata issues this caused in this dataset and you should be able to start new uploads now that correctly skip existing files.

@nellh nellh closed this as completed Jun 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants