Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Determine what histogram buckets look like #62

Closed
brian-brazil opened this issue Oct 18, 2017 · 1 comment
Closed

Determine what histogram buckets look like #62

brian-brazil opened this issue Oct 18, 2017 · 1 comment

Comments

@brian-brazil
Copy link
Collaborator

There have been a few different ways to model histogram buckets proposed, which are largely equivalent.

From a Prometheus standpoint we don't have flexibility here as we process every time series independently and already have this built into our language, so things need to follow what we already do to avoid us having to introduce a openmetrics_histogram_quantile function which would be both ugly and breaking for our users.
We need cumulative buckets which are named based on their inclusive upper bound, including a mandatory +Inf bucket which serves as overflow. There's no explicit underflow, as the first bucket includes everything below it.

For systems other than Prometheus which will be parsing whole Childs at once, converting to upper+lower bounds, de-cumulating or providing midpoints instead should all be a simple transformation.

Do we want to support negative buckets? Prometheus technically supports this, but I've never seen it used in practice and it can cause problems.

@beorn7
Copy link
Collaborator

beorn7 commented Oct 11, 2019

Relevant discussion about negative bucket boundaries: #126 (review)

While practical uses are rare, it is easy to support negative buckets, so we should do it. Both Circonus and Datadog support negative buckets (as examples for hosted metrics providers that have decent implementations of histograms).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants