Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature request] Indicate incomplete visibility of element type #91

Open
sdasda7777 opened this issue Jan 25, 2023 · 1 comment
Open

Comments

@sdasda7777
Copy link
Contributor

I've noticed that the TypeShowHidePresenter is pretty misleading: it shows checkmark for every type where at least one item is visible, even if some are hidden.

On the following picture there are two associations, one of them being hidden, yet the TypeShowHidePresenter makes it seem like all should be visible.

image

The behaviour I would more hope for would be using a tristate checkbox, where checked state would only be shown if all elements are visible, unchecked only if none are visible, and the third state otherwise:

image

@JanBliznicenko
Copy link
Member

Yes, it is misleading. Unfortunately, this is limitation of current implementation of Spec, Morphic and Athens. It would be awesome to have it, but it would take quite a lot of effort I think.
It would probably need to change or create special case of SpCheckBoxTableColumn, SpMorphicTableColumnVisitor, SpMorphicTableCellBuilder, SpCheckBoxPresenter, SpMorphicCheckBoxAdapter, CheckboxMorph and CheckboxButtonMorph, incl. its method drawOnAthensCanvas: from Athens library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants