Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove avahi tests in configure #556

Closed
pierre-labastie opened this issue Oct 29, 2023 · 2 comments · Fixed by #558
Closed

Remove avahi tests in configure #556

pierre-labastie opened this issue Oct 29, 2023 · 2 comments · Fixed by #558

Comments

@pierre-labastie
Copy link

If avahi is not installed, and --disable-avahi is not passed, configure errors out. But this shouldn't happen, since neither AVAHI_CFLAGS nor AVAHI_LIBS nor HAVE_AVAHI is used in the code...

Steps to reproduce the behavior:

  1. Uninstall avahi-dev if it is installed
  2. run configure without passing --disable-avahi
  3. It stops with a message starting with: "configure: error: Package requirements (avahi-client) were not met ..."

Expected behavior
Since avahi is nowhere used, it shouldn't be needed to have configure run to completion.

System Information:

  • reproducible on both debian bookworm and linux from scratch. cups-filters version is 2.0.0
@pierre-labastie
Copy link
Author

This should be fixed by #558

@eli-schwartz eli-schwartz mentioned this issue Mar 8, 2024
Merged
@eli-schwartz
Copy link
Contributor

Indeed, not sure why I didn't notice this to cross-link it, fixed ^^

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

configure.ac: remove final traces of avahi eli-schwartz/cups-filters
2 participants
@eli-schwartz @pierre-labastie