Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HttpClient based DomainClient for cross platform binary transport #291

Closed
8 of 10 tasks
Daniel-Svensson opened this issue Jun 19, 2021 · 0 comments · Fixed by #290
Closed
8 of 10 tasks

Add HttpClient based DomainClient for cross platform binary transport #291

Daniel-Svensson opened this issue Jun 19, 2021 · 0 comments · Fixed by #290
Milestone

Comments

@Daniel-Svensson
Copy link
Member

Daniel-Svensson commented Jun 19, 2021

Add a new cross platform (Including Blazor wasm) more easily extensible DomainClient for the binary protocol.

  • enable binary endpoint to be use on other clients than .Net Framework
  • Add support for blazor wasm where the wcf soap based client has problems
  • Enable easier extensibility such as oath, client side caching, compression etc

Tasks to complete before release

  • Decide on naming (and namespace) for public types and assembly (see PR Add HttpClient based DomainClient for cross platform binary transport  #290 )
  • Merge Change Uri serialization for nullable and complex types #289
  • Try it with both different DefaultHttpCompletionOption and se if latency improves in HeaderOnly for realistic test scenarios (for local CPU limited scenarios the current buffering is best)
  • 'Beta' testing in actual applications
  • Setup tests / testing strategy
    I am currently thinking about creating a new test project with a "main.cs" similar to that of Client.Tests and there setup this DomainClientFactory instead, and then link in all relevant tests.
    The few? tests written directly against WebDomainClient should be reviewed to se if they make sense here as well.
    • Should al integration tests be linked to the new test?
    • It might make sense to move "domainclient/integration tests from client.tests to client.web.tests to make them easier to include via wildcard
  • Strip unneded code from copeid QueryStringConverter
  • Write documentation ( install nuget, setup factory readme for docs and nuget)
  • Update samples
  • Review code analysis bugs
  • Add service uri to ctor

Help Wanted

  1. Read through "Questions to answer" and come with input on all points
  2. Try it out, test the code in real scenarios and give feedback (how is performance, latency etc..(
  3. Go through code
  4. Help with setting up tests
  5. Help with documentation, nuget readme ..
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant